fix: sync-contributors file path mismatch#2389
Open
waygeance wants to merge 1 commit intojson-schema-org:mainfrom
Open
fix: sync-contributors file path mismatch#2389waygeance wants to merge 1 commit intojson-schema-org:mainfrom
waygeance wants to merge 1 commit intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2389 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 672 672
Branches 211 211
=========================================
Hits 672 672 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi @vtushar06, Please review this when you get time |
Contributor
Author
|
Hi @vtushar06 any updates on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Issue Number:
Screenshots/videos:
N/A
If relevant, did you update the documentation?
N/A
Summary
This PR fixes a critical bug in the sync-contributors.yml GitHub Actions workflow that has been silently failing for 14+ months. The workflow was fetching contributor data correctly but writing it to
data/roadmap.jsoninstead ofdata/community-users.json, then attempting to commit the unchangedcommunity-users.jsonfile. This mismatch resulted in no actual updates being made to the contributor list.The fix involves:
data/community-users.json)This restores the weekly contributor sync functionality that should have been running since October 2024.
Does this PR introduce a breaking change?
No
Checklist
Please ensure the following tasks are completed before submitting this pull request.