feat: 🎸 cleanup XDR implementation

Author: streamich

src/xdr/XdrDecoder.ts

@@ -30,7 +30,7 @@ export class XdrDecoder<R extends IReader & IReaderResettable = IReader & IReade
   public readAny(): unknown {
     // Basic implementation - in practice this would need schema info
     // For now, we'll throw as this should be used with schema decoder
-    throw new Error('XdrDecoder.readAny() requires explicit type methods or use XdrSchemaDecoder');
+    throw new Error('not implemented');
   }
 
   /**
@@ -122,17 +122,11 @@ export class XdrDecoder<R extends IReader & IReaderResettable = IReader & IReade
    */
   public readOpaque(size: number): Uint8Array {
     const reader = this.reader;
-    const data = new Uint8Array(size);
-
-    // Read actual data
-    for (let i = 0; i < size; i++) {
-      data[i] = reader.u8();
-    }
+    const data = reader.buf(size);
 
     // Skip padding bytes to reach 4-byte boundary
-    const paddedSize = Math.ceil(size / 4) * 4;
-    const padding = paddedSize - size;
-    reader.skip(padding);
+    const paddedSize = size % 4 === 0 ? size : size + (4 - (size % 4));
+    reader.skip(paddedSize - size);
 
     return data;
   }
@@ -153,20 +147,13 @@ export class XdrDecoder<R extends IReader & IReaderResettable = IReader & IReade
   public readString(): string {
     const size = this.readUnsignedInt();
     const reader = this.reader;
-
-    // Read UTF-8 bytes
-    const utf8Bytes = new Uint8Array(size);
-    for (let i = 0; i < size; i++) {
-      utf8Bytes[i] = reader.u8();
-    }
+    const text = reader.utf8(size);
 
     // Skip padding bytes to reach 4-byte boundary
-    const paddedSize = Math.ceil(size / 4) * 4;
-    const padding = paddedSize - size;
-    reader.skip(padding);
+    const paddedSize = size % 4 === 0 ? size : size + (4 - (size % 4));
+    reader.skip(paddedSize - size);
 
-    // Decode UTF-8 to string
-    return new TextDecoder('utf-8').decode(utf8Bytes);
+    return text;
   }
 
   /**
@@ -182,9 +169,7 @@ export class XdrDecoder<R extends IReader & IReaderResettable = IReader & IReade
    */
   public readArray<T>(size: number, elementReader: () => T): T[] {
     const array: T[] = [];
-    for (let i = 0; i < size; i++) {
-      array.push(elementReader());
-    }
+    for (let i = 0; i < size; i++) array.push(elementReader());
     return array;
   }
 

src/xdr/XdrEncoder.ts

@@ -102,7 +102,6 @@ export class XdrEncoder implements BinaryJsonEncoder {
   public writeHyper(hyper: number | bigint): void {
     const writer = this.writer;
     writer.ensureCapacity(8);
-
     if (typeof hyper === 'bigint') {
       writer.view.setBigInt64(writer.x, hyper, false); // big-endian
     } else {
@@ -171,15 +170,9 @@ export class XdrEncoder implements BinaryJsonEncoder {
     const writer = this.writer;
     const paddedSize = Math.ceil(size / 4) * 4;
     writer.ensureCapacity(paddedSize);
-
-    // Write data
     writer.buf(data, size);
-
-    // Write padding bytes
     const padding = paddedSize - size;
-    for (let i = 0; i < padding; i++) {
-      writer.u8(0);
-    }
+    for (let i = 0; i < padding; i++) writer.u8(0);
   }
 
   /**
@@ -202,13 +195,9 @@ export class XdrEncoder implements BinaryJsonEncoder {
     const lengthOffset = writer.x;
     writer.x += 4; // Reserve space for length
     const bytesWritten = writer.utf8(str);
-
-    // Calculate and write padding
     const paddedSize = Math.ceil(bytesWritten / 4) * 4;
     const padding = paddedSize - bytesWritten;
-    for (let i = 0; i < padding; i++) {
-      writer.u8(0);
-    }
+    for (let i = 0; i < padding; i++) writer.u8(0);
 
     // Go back and write the actual byte length
     const currentPos = writer.x;
@@ -232,14 +221,9 @@ export class XdrEncoder implements BinaryJsonEncoder {
    */
   public writeNumber(num: number): void {
     if (Number.isInteger(num)) {
-      if (num >= -2147483648 && num <= 2147483647) {
-        this.writeInt(num);
-      } else {
-        this.writeHyper(num);
-      }
-    } else {
-      this.writeDouble(num);
-    }
+      if (num >= -2147483648 && num <= 2147483647) this.writeInt(num);
+      else this.writeHyper(num);
+    } else this.writeDouble(num);
   }
 
   /**

src/xdr/__tests__/XdrDecoder.spec.ts

@@ -278,12 +278,12 @@ describe('XdrDecoder', () => {
   describe('decode method', () => {
     test('decode method calls readAny which throws', () => {
       const encoded = new Uint8Array([0, 0, 0, 42]);
-      expect(() => decoder.decode(encoded)).toThrow('XdrDecoder.readAny() requires explicit type methods');
+      expect(() => decoder.decode(encoded)).toThrow('not implemented');
     });
 
     test('read method calls readAny which throws', () => {
       const encoded = new Uint8Array([0, 0, 0, 42]);
-      expect(() => decoder.read(encoded)).toThrow('XdrDecoder.readAny() requires explicit type methods');
+      expect(() => decoder.read(encoded)).toThrow('not implemented');
     });
   });