Fix JSON decoder bug with small floats like 0.0000040357127006276845#47
Merged
Fix JSON decoder bug with small floats like 0.0000040357127006276845#47
Conversation
Co-authored-by: streamich <9773803+streamich@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] JSON codec bug with small floats
Fix JSON decoder bug with small floats like 0.0000040357127006276845
Aug 8, 2025
|
🎉 This PR is included in version 1.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
JsonDecoderwas incorrectly handling small floats with exactly 24 characters due to a typo in thereadNum()method. When parsing numbers character by character, the decoder was missingc23and duplicatingc24in thefromCharCodecall, causing precision loss.Problem:
Root Cause:
In
JsonDecoder.tsline 587, thefromCharCodecall was missingc23:Fix:
c23andc24in the proper orderAfter the fix:
Fixes #46.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.