Improved FAQ and examples for getting/using filenames

Author: jstedfast

Documentation/Examples/AttachmentExamples.cs

@@ -27,18 +27,27 @@ public static void SaveAttachments (MimeMessage message)
 			#region SaveAttachments
 			foreach (var attachment in message.Attachments) {
 				if (attachment is MessagePart) {
-					var fileName = attachment.ContentDisposition?.FileName;
+					var fileName = attachment.ContentDisposition?.FileName ?? attachment.ContentType.Name;
 					var rfc822 = (MessagePart) attachment;
 
 					if (string.IsNullOrEmpty (fileName))
 						fileName = "attached-message.eml";
 
+					// make sure that the filename value does not contain a full path or invalid path characters
+					fileName = Path.GetFileName (fileName);
+
 					using (var stream = File.Create (fileName))
 						rfc822.Message.WriteTo (stream);
 				} else {
 					var part = (MimePart) attachment;
 					var fileName = part.FileName;
 
+					if (string.IsNullOrEmpty (fileName))
+						fileName = "untitled.dat";
+
+					// make sure that the filename value does not contain a full path or invalid path characters
+					fileName = Path.GetFileName (fileName);
+
 					using (var stream = File.Create (fileName))
 						part.Content.DecodeTo (stream);
 				}
@@ -54,18 +63,27 @@ public static void SaveAttachments (MimeMessage message)
 					continue;
 
 				if (bodyPart is MessagePart) {
-					var fileName = attachment.ContentDisposition?.FileName;
+					var fileName = attachment.ContentDisposition?.FileName ?? attachment.ContentType.Name;
 					var rfc822 = (MessagePart) attachment;
 
 					if (string.IsNullOrEmpty (fileName))
 						fileName = "attached-message.eml";
 
+					// make sure that the filename value does not contain a full path or invalid path characters
+					fileName = Path.GetFileName (fileName);
+
 					using (var stream = File.Create (fileName))
 						rfc822.Message.WriteTo (stream);
 				} else {
 					var part = (MimePart) attachment;
 					var fileName = part.FileName;
 
+					if (string.IsNullOrEmpty (fileName))
+						fileName = "untitled.dat";
+
+					// make sure that the filename value does not contain a full path or invalid path characters
+					fileName = Path.GetFileName (fileName);
+
 					using (var stream = File.Create (fileName))
 						part.Content.DecodeTo (stream);
 				}

FAQ.md

@@ -968,6 +968,12 @@ If you are iterating over all of the attachments in a message, you might do some
 foreach (var attachment in message.Attachments) {
     var fileName = attachment.ContentDisposition?.FileName ?? attachment.ContentType.Name;
 
+    if (string.IsNullOrEmpty (fileName))
+        fileName = "untitled.dat";
+
+    // make sure that the filename value does not contain a full path or invalid path characters
+    fileName = Path.GetFileName (fileName);
+
     using (var stream = File.Create (fileName)) {
         if (attachment is MessagePart) {
             var rfc822 = (MessagePart) attachment;