[Fix] most_appropiate_url changed to be part of Paperclip::UrlGenerator,...#62
[Fix] most_appropiate_url changed to be part of Paperclip::UrlGenerator,...#62tommeier wants to merge 1 commit into
Conversation
…or, tested across rails versions and added Rails 3.2 to test suite. Paperclip version bumped to 2.7. - Main issue - `attachment`_updated_at was not being updated, new Paperclip (> 2.4.5) assigns the updated_at of the `attachment`, when S3 took too long, or the queue takes longer than a second to pick the image up, the `attachment`_updated_at and instance.updated_at get out of sync, and the url generated (with :updated_at in the hash_data - default), will not find the newly created images.
|
A month later this is still working perfectly in a production system with S3 delayed back ups via a Resque queue. |
|
Works for me too (well done tommeier) - about time someone merges?!? Paperclip (which is active) has a reference to this gem (with its last push 4 months ago) in the Wiki - although clearly delayed_paperclip is currently incompatible with the latest Paperclip version. Those interested in tommeier's commit can ref it from their Gemfile as such: |
|
+1 |
3 similar comments
|
+1 |
|
+1 |
|
👍 |
|
Updated : Now use this branch for Paperclip 3.1.2 + So in gemfile : |
|
+1 |
|
Thanks, tommeier. Maybe we could update the gem at rubygems.org too, because this will be the most useful version for everybody using current paperclip & rails. What do you think? |
|
Thanks tommeier. |
|
Thanks @tommeier - worked for me! :) |
|
+1 for a merge? |
|
@tibbon it was merged into the new upstream. i adopted delayed_paperclip, so it's merged in. you can now update your gem. |
|
Oh thanks! Just saw that while looking at the network. Trying to figure out On Thu, Jan 10, 2013 at 8:39 AM, James Gifford notifications@github.comwrote:
|
Fix for when attachment is set on a parent class (eg ActiveRecords STI) The only_process was nil which wasn't being checked against [] very well only_process now defaults to []
... tested across rails versions and added Rails 3.2 to test suite. Paperclip version bumped to 2.7.
Main issue :