Fix ESLint v10 RuleContext API removal (follow-up to #3972)

[ledsun]

This PR follows up on the feedback in the comments of #3972 and incorporates the requested changes.

I think this PR will fix #3977.

[ljharb]

we'll need regression tests - it might be as simple as adding eslint 10 to the GHA matrix.

[codecov]

Codecov Report

❌ Patch coverage is 49.49495% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.26%. Comparing base (9af8845) to head (ea44283).

Files with missing lines	Patch %	Lines
lib/util/eslint.js	21.87%	50 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3979      +/-   ##
==========================================
+ Coverage   94.76%   97.26%   +2.50%     
==========================================
  Files         134      137       +3     
  Lines       10165    10252      +87     
  Branches     3794     3833      +39     
==========================================
+ Hits         9633     9972     +339     
+ Misses        532      280     -252     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[karlnorling]

@ledsun do you have time to address the failing checks. I'm looking at updating to eslint 10 and we're using the eslint-plugin-react

[wdhowell84]

rebasing here should leave only a small number of red cells, all of which look like the matrix flakiness tracked in #4007

Since that PR was merged and so was a PR that closed #4007, can this be rebased? Will that allow this to be merged, or is it also waiting on import-js/eslint-plugin-import#3230 (which needs a new review following rasmi addressing its feedback)?

I rebased and ran some local tests on a fork. I think we are just waiting to get unblocked on [import-js/eslint-plugin-import#3230]. Any remaining cleanup after that should be pretty straight forward.

They now seem to be one requested change and/or review away. CodeCov finally shut up about the 3.15% coverage it still wanted. This all may be coming to an end soon. Yay!

[wdhowell84]

eslint-plugin-import work has been merged successfully: import-js/eslint-plugin-import#3230

[lumirlumir]

Sorry for the ping, but I wanted to check whether there are any updates on this PR.

There have been some issues and blocked PRs on the ESLint side where things depend on eslint-plugin-react, so it would be great to make progress here if possible. (If helpful, I’d also be happy to contribute a PR to help move this forward.) Thank you.

Just for reference:

• Bug: Adding react support causes peer dependency conflict eslint/create-config#248
• chore: update eslint-dev (major) eslint/eslint.org#965
• https://github.com/eslint/markdown/blob/main/examples/react/package.json#L8-L10
• ...

[lorand-horvath]

There was a long waiting on import-js/eslint-plugin-import#3230 but it was finally merged on June 28-29, however no release has been made for it yet, since there are other issues that seem to need fixing first, see the newer commits made since then: https://github.com/import-js/eslint-plugin-import/commits/main/

[RSS1102]

Is there a small portion of demand? It's been a long time since I woke up @ljharb

[BearCooder]

Hey is someone updating the PR? If not I can help, from last comments I am not sure