Fix ESLint v10 RuleContext API removal (follow-up to #3972) by ledsun · Pull Request #3979 · jsx-eslint/eslint-plugin-react

ledsun · 2026-02-09T02:35:00Z

This PR follows up on the feedback in the comments of #3972 and incorporates the requested changes.

I think this PR will fix #3977.

ljharb

we'll need regression tests - it might be as simple as adding eslint 10 to the GHA matrix.

@ledsun

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

@ledsun

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

codecov · 2026-02-11T08:15:43Z

Codecov Report

❌ Patch coverage is 49.49495% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.26%. Comparing base (9af8845) to head (ea44283).

Files with missing lines	Patch %	Lines
lib/util/eslint.js	21.87%	50 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3979      +/-   ##
==========================================
+ Coverage   94.76%   97.26%   +2.50%     
==========================================
  Files         134      137       +3     
  Lines       10165    10252      +87     
  Branches     3794     3833      +39     
==========================================
+ Hits         9633     9972     +339     
+ Misses        532      280     -252

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

karlnorling · 2026-03-02T14:06:49Z

@ledsun do you have time to address the failing checks. I'm looking at updating to eslint 10 and we're using the eslint-plugin-react

…-react/eslint-plugin (#27011) ## Summary - Replace `eslint-plugin-react` (~7.37.5) with `@eslint-react/eslint-plugin` (~2.13.0) in `@fluidframework/eslint-config-fluid` to unblock ESLint 10 adoption - Use the `recommended-typescript` preset which auto-disables rules already handled by TypeScript - Keep `eslint-plugin-react-hooks` separately — it already has ESLint 10 support and provides React Compiler rules - Switch `print-configs` script from `tsx` to `jiti` to fix ESM-only package resolution ### Why `eslint-plugin-react` 7.37.5 is broken with ESLint 10 — it calls `context.getFilename()` which was removed. The upstream fix ([jsx-eslint/eslint-plugin-react#3979](jsx-eslint/eslint-plugin-react#3979)) has been blocked since February 2026. `@eslint-react` v2.13.0 supports ESLint 8/9/10, so this works now and won't block the ESLint 10 upgrade. ### Consumer updates Per-package eslint config and package.json updates (rule renames, removing redundant devDeps) will come in a follow-up PR stacked on this one. Resolves #27009

karlnorling · 2026-04-28T19:44:34Z

What's the status on this PR? Do we need to open another one? Seems we're just waiting for CI to pass? @ljharb ?

ljharb · 2026-04-28T19:45:56Z

Yes, it needs to be rebased and the test failures fixed. Please do NOT open a redundant PR; if you have changes you want added, comment with a branch or commit link, and I'll pull them in.

modeitsch · 2026-04-29T09:04:20Z

I checked this from a local checkout of 635cd2ce. It looks like the branch is not behind master anymore:

git rev-list --left-right --count origin/master...HEAD
# 0 2

gh pr checks 3979 --repo jsx-eslint/eslint-plugin-react is also green for the current head, including the ESLint 10 type-check jobs. If GitHub is still showing this as stale/failing somewhere, it may be cached PR metadata rather than an actual rebase/test failure.

lorand-horvath · 2026-04-29T10:39:24Z

I've pushed some of the commits from this PR to master, but it looks like we're blocked on import-js/eslint-plugin-import#3227.

@ljharb Is it still the case, i.e. blocked on eslint-plugin-import?

Two upstream incompatibilities prevented lint from running: - eslint-config-next bundles typescript-eslint@8.48 whose @typescript-eslint/utils still does `class FlatESLint extends use_at_your_own_risk.FlatESLint` directly. ESLint 10 removed FlatESLint so this crashes on require. 8.59+ falls back to ESLint when FlatESLint is undefined. Forced via resolutions. - eslint-plugin-react's React-version auto-detection calls context.getFilename(), removed in ESLint 10. Workaround per vercel/next.js#89764: hardcode the React version in settings. Both workarounds are commented inline with the upstream tracking links so they can be removed once eslint-config-next ships with typescript-eslint >= 8.49 and eslint-plugin-react ships jsx-eslint/eslint-plugin-react#3979. With lint actually running, three pre-existing no-useless-assignment errors surfaced in DataTable.tsx and FeaturesClusterMarker.tsx (let foo = <default> followed by a fully-covering if/else chain). Fixed by dropping the dead initial assignment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

lorand-horvath · 2026-05-08T05:26:54Z

Would it be an option to move to an eslint 10 compatible plugin like eslint-plugin-import-x?

No.

@ljharb Why not? It's not like this one is compatible with eslint 10 or something. When will it be fixed?

ljharb reviewed Feb 10, 2026

View reviewed changes

ljharb marked this pull request as draft February 10, 2026 02:09

sergeyklay added a commit to sergeyklay/oar that referenced this pull request Feb 10, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0

72b1aaf

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

sergeyklay mentioned this pull request Feb 10, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0 sergeyklay/oar#269

Merged

sergeyklay added a commit to sergeyklay/oar that referenced this pull request Feb 10, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.0.0

30bc6ee

Use @ledsun fork. For more see: - jsx-eslint/eslint-plugin-react#3977 - jsx-eslint/eslint-plugin-react#3979

sergeyklay mentioned this pull request Feb 10, 2026

Track reverting to upstream eslint after temporary fork sergeyklay/oar#270

Closed

Copilot AI mentioned this pull request Feb 10, 2026

docs: create ESLint 10 compatibility tracking document sergeyklay/oar#271

Closed

sergeyklay mentioned this pull request Feb 10, 2026

Tracking: ESLint 10 Support sergeyklay/oar#272

Closed

6 tasks

ledsun force-pushed the update-deprecated-calls-v8 branch from f987ffa to a7b967b Compare February 11, 2026 08:06

ledsun marked this pull request as ready for review February 11, 2026 12:08

domarmstrong reviewed Feb 12, 2026

View reviewed changes

Comment thread lib/util/eslint.js Outdated

Comment thread lib/util/version.js Outdated

ljharb reviewed Feb 12, 2026

View reviewed changes

Comment thread lib/util/makeNoMethodSetStateRule.js

ljharb requested changes Feb 13, 2026

View reviewed changes

Comment thread .github/workflows/node-18+.yml Outdated

Comment thread lib/util/version.js Outdated

Comment thread package.json Outdated

This was referenced Feb 14, 2026

Downgrade ESLint to v9.39.2 due to plugin incompatibility cybersemics/em#3804

Closed

Add ESLint v10 required dependencies and restore .eslintignore qlik-oss/nebula.js#1906

Closed

lpicchi mentioned this pull request Feb 17, 2026

ESLint v10 compatibility #3977

Open

2 tasks

This was referenced Feb 18, 2026

Add pnpm patch for eslint-plugin-react ESLint 10 compatibility tdkn/blog#1987

Closed

docs: ESLint 10 upgrade investigation and compatibility analysis Amsterdam/design-system#2426

Closed

testower mentioned this pull request Feb 19, 2026

ESLint 10 upgrade deferred opentripplanner/OpenTripPlanner#7319

Open

tresdonicf mentioned this pull request Feb 19, 2026

Task: Upgrade to eslint 10 Enterprise-CMCS/demos#846

Closed

ljharb reviewed Feb 19, 2026

View reviewed changes

Comment thread .github/workflows/eslint-9+.yml Outdated

Comment thread .github/workflows/eslint-8-.yml

Comment thread .github/workflows/eslint-9+.yml Outdated

ledsun force-pushed the update-deprecated-calls-v8 branch from 6a95ab9 to 13c7805 Compare February 21, 2026 08:05

StyleShit mentioned this pull request Feb 22, 2026

chore: update eslint to 10.x [AR-48952] drivenets/design-system#186

Merged

Snoww3d mentioned this pull request Feb 22, 2026

chore: migrate eslint 9 → 10 Snoww3d/jwst-data-analysis#347

Closed

casaub0n mentioned this pull request Feb 24, 2026

ESLint v10 casaub0n/casaub0n#6036

Closed

ARADDCC002 mentioned this pull request Feb 25, 2026

Update frontend to use ESLint v10 gchq/Bailo#3286

Open

ActiveChooN mentioned this pull request Feb 25, 2026

📋 [TASK] Migrate ESLint to v10 open-edge-platform/anomalib#3373

Open

casaub0n mentioned this pull request Mar 1, 2026

update eslint version casaub0n/casaub0n#6192

Merged

danielhjacobs mentioned this pull request Apr 14, 2026

build(deps-dev): bump eslint from 9.39.3 to 10.0.3 ruffle-rs/ruffle-rs.github.io#529

Merged

danielhjacobs mentioned this pull request Apr 15, 2026

Compatibility with ESLint 10 import-js/eslint-plugin-import#3227

Open

ParcostaBot mentioned this pull request Apr 17, 2026

chore(deps-dev): bump eslint from 9.39.2 to 10.2.0 Parcosta/c2c-website#84

Closed

charles4221 mentioned this pull request Apr 20, 2026

Upgrade to ESLint v10 FortAwesome/react-fontawesome#640

Open

9 tasks

charles4221 linked an issue Apr 20, 2026 that may be closed by this pull request

Upgrade to ESLint v10 FortAwesome/react-fontawesome#640

Open

9 tasks

johnmeshulam mentioned this pull request Apr 21, 2026

Migrate to eslint 10 FIRSTIsrael/lems#2028

Open

This was referenced Apr 23, 2026

PF-DEP: Re-attempt eslint v10 upgrade once eslint-plugin-react fix lands Tristan578/project-forge#8493

Open

chore(deps-dev): bump eslint from 9.39.4 to 10.2.1 in /web Tristan578/project-forge#8476

Closed

mannism mentioned this pull request Apr 24, 2026

chore(deps-dev): bump eslint from 9.39.4 to 10.2.1 mannism/labs#47

Closed

pawiecz mentioned this pull request Apr 24, 2026

Resolve ESLint upgrade conflicts roostorg/coop#68

Open

ljharb mentioned this pull request Apr 24, 2026

[New] jsx-no-leaked-render: add ignoreAttributes option #3441

Merged

1 task

dopenguin mentioned this pull request Apr 27, 2026

feat(deps)!: upgrade to ESLint 10 neostandard/neostandard#355

Draft

5 tasks

xtan9 mentioned this pull request Apr 28, 2026

chore(deps): TypeScript 6 + ESLint 10 (A1 PR 2/5) xtan9/youtubeai_chat_frontend#50

Merged

6 tasks

sugarshin mentioned this pull request Apr 28, 2026

Upgrade to Expo SDK 55 sugarshin/seam#48

Merged

9 tasks

davideluque mentioned this pull request Apr 29, 2026

Build(deps-dev): Bump eslint from 9.39.1 to 10.3.0 abtion/abtion-secret#2877

Closed

Skords-01 mentioned this pull request May 4, 2026

feat(web): add <DataState> wrapper for RQ loading/empty/error/stale Skords-01/Sergeant#1588

Merged

9 tasks

lo1tuma mentioned this pull request May 4, 2026

Add config-combo integration tests; fix three issues they uncovered enormora/eslint-config#637

Merged

coderabbitai Bot mentioned this pull request May 4, 2026

feat(database): setup backend with drizzle orm and configure eslint BhushanLagare7/northwind#1

Merged

cffnpwr mentioned this pull request May 5, 2026

eslint monorepo を v10 へ更新 cffnpwr/eslint-config#112

Open

3 tasks

samjewell mentioned this pull request May 5, 2026

chore(deps): update dependency eslint to v10 grafana/grafana-cube-datasource#112

Closed

1 task

This comment was marked as resolved.

Sign in to view

captaindonald mentioned this pull request May 10, 2026

[Tests] drop ESLint-10-incompatible 'type:' property from RuleTester error assertions #4006

Open

3 tasks

Uh oh!

Conversation

ledsun commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

karlnorling commented Mar 2, 2026

Uh oh!

karlnorling commented Apr 28, 2026

Uh oh!

ljharb commented Apr 28, 2026

Uh oh!

modeitsch commented Apr 29, 2026

Uh oh!

lorand-horvath commented Apr 29, 2026

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

lorand-horvath commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

11 participants

ledsun commented Feb 9, 2026 •

edited

Loading

codecov Bot commented Feb 11, 2026 •

edited

Loading