[Fix] no-unknown-property : add missing CSS transition event handlers#4001
[Fix] no-unknown-property : add missing CSS transition event handlers#4001baevm wants to merge 1 commit into
no-unknown-property : add missing CSS transition event handlers#4001Conversation
f47b696 to
9d6ff73
Compare
no-unknown-property : allow CSS transition event handlersno-unknown-property : add missing CSS transition event handlers
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support in no-unknown-property for additional CSS transition event handler props so they’re not incorrectly flagged as unknown, and documents the change in the changelog.
Changes:
- Add
onTransitionCancel,onTransitionRun, andonTransitionStart(and Capture variants) to the allowed DOM property list inno-unknown-property. - Update
CHANGELOG.mdto record the fix and add the PR reference link.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/rules/no-unknown-property.js | Extends the allowlist to include missing transition event handler props (including Capture variants). |
| CHANGELOG.md | Documents the rule update and adds the PR link reference. |
Comments suppressed due to low confidence (1)
CHANGELOG.md:1
- There are two consecutive blank lines inserted after the new entry, which adds unnecessary whitespace and can make the changelog harder to scan. Consider removing the extra blank line(s) to keep formatting consistent (typically a single blank line between sections).
# Change Log
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9d6ff73 to
eda9644
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4001 +/- ##
==========================================
- Coverage 97.58% 95.91% -1.67%
==========================================
Files 137 137
Lines 10182 10182
Branches 3795 3795
==========================================
- Hits 9936 9766 -170
- Misses 246 416 +170 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eda9644 to
8f6fa9e
Compare
I added tests, but some CI checks are failing with cryptic errors, and im not sure why |
this PR adds support for
onTransitionCancel,onTransitionCancelCapture,onTransitionRun,onTransitionRunCapture,onTransitionStart,onTransitionStartCaptureevents inno-unknown-propertyrule. Fixes #3993