[Fix] no-unknown-property : add missing CSS transition event handlers#4001
Open
baevm wants to merge 1 commit into
Open
[Fix] no-unknown-property : add missing CSS transition event handlers#4001baevm wants to merge 1 commit into
no-unknown-property : add missing CSS transition event handlers#4001baevm wants to merge 1 commit into
Conversation
baevm
force-pushed
the
no-unknown-property/add-css-transitions
branch
from
f47b696 to
9d6ff73
Compare
baevm
changed the title
no-unknown-property : allow CSS transition event handlersno-unknown-property : add missing CSS transition event handlers
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support in no-unknown-property for additional CSS transition event handler props so they’re not incorrectly flagged as unknown, and documents the change in the changelog.
Changes:
- Add
onTransitionCancel,onTransitionRun, andonTransitionStart(and Capture variants) to the allowed DOM property list inno-unknown-property. - Update
CHANGELOG.mdto record the fix and add the PR reference link.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/rules/no-unknown-property.js | Extends the allowlist to include missing transition event handler props (including Capture variants). |
| CHANGELOG.md | Documents the rule update and adds the PR link reference. |
Comments suppressed due to low confidence (1)
CHANGELOG.md:1
- There are two consecutive blank lines inserted after the new entry, which adds unnecessary whitespace and can make the changelog harder to scan. Consider removing the extra blank line(s) to keep formatting consistent (typically a single blank line between sections).
# Change Log
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baevm
force-pushed
the
no-unknown-property/add-css-transitions
branch
from
9d6ff73 to
eda9644
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4001 +/- ##
==========================================
- Coverage 97.58% 95.91% -1.67%
==========================================
Files 137 137
Lines 10182 10182
Branches 3795 3795
==========================================
- Hits 9936 9766 -170
- Misses 246 416 +170 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
baevm
force-pushed
the
no-unknown-property/add-css-transitions
branch
from
eda9644 to
8f6fa9e
Compare
Author
I added tests, but some CI checks are failing with cryptic errors, and im not sure why |
masoudamiri1134
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds support for
onTransitionCancel,onTransitionCancelCapture,onTransitionRun,onTransitionRunCapture,onTransitionStart,onTransitionStartCaptureevents inno-unknown-propertyrule. Fixes #3993