Skip to content

Commit 2a69e2b

Browse files
committed
docs: fix navigation and scroll behavior on GitHub Pages
- Add "Advanced Features" link to header and mobile navigation - Implement CSS native smooth scrolling and scroll-padding-top - Remove conflicting smoothscroll.min.js script to fix "jump back" issue
1 parent 388796b commit 2a69e2b

5 files changed

Lines changed: 3 additions & 4 deletions

File tree

.eslintignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,5 @@ dist/
33
tmp/
44
examples/bundle.js
55
examples/commonjs.bundle.js
6-
examples/smoothscroll.min.js
76
coverage/
87
test/fixtures/coverage.js

.github/workflows/main.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ jobs:
109109
-e 's|\.\./angular-chart.js|dist/angular-chart.js|g' \
110110
-e 's|href="app.css"|href="examples/app.css"|g' \
111111
-e 's|src="app.js"|src="examples/app.js"|g' \
112-
-e 's|src="smoothscroll.min.js"|src="examples/smoothscroll.min.js"|g' \
113112
examples/charts.html > deploy/index.html
114113
115114
- name: Setup Pages

examples/app.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
html { scroll-padding-top: 60px; scroll-behavior: smooth; }
12
body { padding-top: 50px; }
23

34
.nav, .pagination, .carousel, .panel-title a { cursor: pointer; }

examples/charts.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,14 @@
7171
<li><a href="#getting_started">Getting started</a></li>
7272
<li><a href="#reactive">Reactive</a></li>
7373
<li><a href="#mixed">Mixed type charts</a></li>
74+
<li><a href="#advanced">Advanced Features</a></li>
7475
</ul>
7576
</nav>
7677
<nav class="collapse" collapse="isCollapsed" style="height: 0px;">
7778
<ul class="nav navbar-nav">
7879
<li><a href="#getting_started" ng-click="isCollapsed = !isCollapsed">Getting started</a></li>
7980
<li><a href="#directives" ng-click="isCollapsed = !isCollapsed">Directives</a></li>
81+
<li><a href="#advanced" ng-click="isCollapsed = !isCollapsed">Advanced Features</a></li>
8082
</ul>
8183
</nav>
8284
</div>
@@ -736,7 +738,6 @@ <h1>Advanced Features</h1>
736738
<script src="../node_modules/rainbow-code/src/language/html.js"></script>
737739
<script src="../node_modules/rainbow-code/src/language/javascript.js"></script>
738740
<script src="../dist/angular-chart.js"></script>
739-
<script src="smoothscroll.min.js"></script>
740741
<script src="app.js"></script>
741742
<script>
742743
(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){

examples/smoothscroll.min.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)