Skip to content

Commit 8fa7af6

Browse files
committed
fix: restore dropdown functionality and slugify chart IDs
1 parent cd4c4a7 commit 8fa7af6

2 files changed

Lines changed: 12 additions & 5 deletions

File tree

examples/app.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,13 @@
1919
tooltips: {enabled: false},
2020
});
2121
});
22+
+
23+
+ app.filter('slug', () => {
24+
+ return (input) => {
25+
+ if (!input) return '';
26+
+ return input.toLowerCase().replace(/ /g, '-');
27+
+ };
28+
+ });
2229

2330
app.controller('MenuCtrl', ['$scope', ($scope) => {
2431
$scope.isCollapsed = true;

examples/charts.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,12 @@
6060
Angular Chart
6161
</a>
6262
</li>
63-
<li class="dropdown">
64-
<a role="button" class="dropdown-toggle" aria-haspopup="true" aria-expanded="false">
63+
<li class="dropdown" dropdown>
64+
<a role="button" class="dropdown-toggle" dropdown-toggle aria-haspopup="true" aria-expanded="false">
6565
Directives <b class="caret"></b>
6666
</a>
6767
<ul class="dropdown-menu">
68-
<li ng-repeat="chart in charts"><a ng-href="#{{chart | lowercase }}-chart">{{chart}}</a></li>
68+
<li ng-repeat="chart in charts"><a ng-href="#{{chart | slug }}-chart">{{chart}}</a></li>
6969
</ul>
7070
</li>
7171
<li><a href="#getting_started">Getting started</a></li>
@@ -431,7 +431,7 @@ <h1>Directives</h1>
431431
</tab>
432432
</tabset>
433433
</div>
434-
<div class="col-lg-6 col-sm-12" id="polar area-chart" ng-controller="PolarAreaCtrl">
434+
<div class="col-lg-6 col-sm-12" id="polar-area-chart" ng-controller="PolarAreaCtrl">
435435
<div class="panel panel-default">
436436
<div class="panel-heading">Polar Area Chart</div>
437437
<div class="panel-body">
@@ -442,7 +442,7 @@ <h1>Directives</h1>
442442
</div>
443443
</div>
444444
<div class="row">
445-
<div class="col-lg-6 col-sm-12" id="horizontal bar-chart" ng-controller="BarCtrl">
445+
<div class="col-lg-6 col-sm-12" id="horizontal-bar-chart" ng-controller="BarCtrl">
446446
<div class="panel panel-default">
447447
<div class="panel-heading">Horizontal Bar Chart</div>
448448
<div class="panel-body">

0 commit comments

Comments
 (0)