Add GetNodeByNodeKey API endpoint for O(1) node lookup#3138
Open
sbatista-uc wants to merge 3 commits into
Open
Add GetNodeByNodeKey API endpoint for O(1) node lookup#3138sbatista-uc wants to merge 3 commits into
sbatista-uc wants to merge 3 commits into
Conversation
Instead of listing all nodes and filtering client-side, this exposes the
existing in-memory NodeStore.GetNodeByNodeKey as a gRPC/REST endpoint at
GET /api/v1/node/by-node-key/{node_key}. Returns the full Node proto
including the online status field.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tests cover: successful lookup, not-found, invalid key formats (empty, garbage, truncated), and online status field population. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
…t/get-node-by-key-clean # Conflicts: # hscontrol/grpcv1_test.go
Collaborator
|
There is an upcoming milestone where we likely will replace the api so I have not spent any time on anything that would change the current one as it likely will be replaced again. #2305 |
Author
|
Sounds good, as you refactor the API I would appreciate if you keep in mind my request to get a node by ID. Thanks in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the existing in-memory NodeStore.GetNodeByNodeKey as a gRPC/REST endpoint at GET /api/v1/node/by-node-key/{node_key}. Returns the full Node proto including the online status field.
#3137