fix: bundle generated warmer handler to avoid missing @smithy runtime dependency#364
Open
caaarlxs wants to merge 6 commits intojuanjoDiaz:mainfrom
Open
fix: bundle generated warmer handler to avoid missing @smithy runtime dependency#364caaarlxs wants to merge 6 commits intojuanjoDiaz:mainfrom
caaarlxs wants to merge 6 commits intojuanjoDiaz:mainfrom
Conversation
Author
|
This PR should also address issue #365 (ERR_MODULE_NOT_FOUND with @smithy/node-http-handler). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: When using Serverless Framework v4 (or packaging with warmup patterns that only include .warmup/**), the generated warmup handler imports @smithy/node-http-handler (and @aws-sdk/client-lambda) but the warmer artifact does not include node_modules, causing runtime ERR_MODULE_NOT_FOUND.
Root cause: The plugin’s default packaging pattern excludes node_modules, but the generated handler depends on external modules.
Change: After writing .warmup//index.mjs, bundle it with esbuild into a self-contained ESM file and replace the original index.mjs.
Result: The warmer artifact remains minimal and works without requiring users to manually include node_modules patterns; fixes missing module errors for @smithy/*.
Verification: