[Bug]: juce_gui_extra.cpp defaults to including web browser ignoring CMake option

[inkychris]

Detailed steps on how to reproduce the bug

When using, for example, juce_add_gui_app() and with the default option of NEEDS_WEB_BROWSER set to false, the following in juce_gui_extra.h causes attempts to import headers in juce_gui_extra.cpp that are then correctly not linked by cmake, causing a build error:

JUCE/modules/juce_gui_extra/juce_gui_extra.h

Lines 75 to 77 in 3ba67d4

	#ifndef JUCE_WEB_BROWSER
	#define JUCE_WEB_BROWSER 1
	#endif

Workaround is to set the compile definition JUCE_WEB_BROWSER=0 but given the default is this already when adding the target, this definition should be set to 0 by default, or the setting of it in that file should be removed so it's only ever explicitly defined when enabled.

What is the expected behaviour?

Builds successfully.

Operating systems

Linux

What versions of the operating systems?

Fedora 44.

Architectures

x86_64

Stacktrace

Plug-in formats (if applicable)

No response

Plug-in host applications (DAWs) (if applicable)

No response

Testing on the develop branch

I have not tested against the develop branch

Code of Conduct

• I agree to follow the Code of Conduct

[reuk]

Thanks for the report. We've added a fix to automatically set the preprocessor definitions based on the arguments of juce_add_.* here (juce9 branch)

d911ac8