Fixed activeEditor wild pointer issue when destroying plug-in window in AudioPluginHost

[Sqazine]

Problem description:

When I debugged my plug-in on 8.0.12 version, I found that the plug-in window opened normally the first time, but only a default window opened the second time.At first I thought there was something wrong with my plug-in code.So i debug AudioPluginHost's internal plugin,and found the same situation.

First Open:

Close the plugin window and reopen:

This happens with all plugins that have an editor.Not a specific one.

Problem analysis:

So i debug AudioPluginHost project.When I open the plugin window the second time, this place will report an error:

And the activeEditor member seens invalid.

activeEditor is a raw pointer member of AudioProcessor class.

So i debug 7.0.12 version,no matter how many times I open the plug-in window, it always displays correctly.And the activeEditor member is a safe pointer:

And in AudioProcessor::createEditorIfNeeded(),it always a pretty null pointer

So i think in version 8.0.12, the object pointed to by the activeEditor pointer has been destroyed, but the activeEditor is not set to null, resulting in a wild pointer.

My solution

So I use the editorBeingDeleted() function, with AudioProcessor's own editor as an argument, to set the AudioProcessor's activeEditor member to null before deleting the plug-in editor.As below.

[reuk]

Thanks for reporting! This issue has been fixed on the develop branch:

8840ac4

[Sqazine]

Great!