SystemStats: Make Windows+Clang callCPUID() clear ECX like __cpuid()#1640
Closed
why-trv wants to merge 1 commit into
Closed
SystemStats: Make Windows+Clang callCPUID() clear ECX like __cpuid()#1640why-trv wants to merge 1 commit into
why-trv wants to merge 1 commit into
Conversation
…intrinsic Previously, ECX could contain result from a previous callCPUID() call, breaking, for instance, AVX2 and AVX512 detection
Collaborator
|
This pull request has been mentioned on The JUCE Forum. There might be relevant details there: https://forum.juce.com/t/bug-report-wrong-systemstats-hasavx2-result-with-clang-cl-64-bit/68580/2 |
Member
|
Thank you for reporting. I've added a fix here: 28706b9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes AVX2 and AVX512 detection issues with clang-cl on Windows (https://forum.juce.com/t/bug-report-wrong-systemstats-hasavx2-result-with-clang-cl-64-bit/68580).
Previously, ECX could contain result from a previous callCPUID() call, so the result would be some other leaf, not EAX=7, ECX=0.