Add a Linux accessibility backend (AT-SPI 2)#1667
Open
omartijn wants to merge 2 commits into
Open
Conversation
8e85ab7 to
269bd17
Compare
A closed menu's items have no Components until it opens, so assistive tech could neither discover nor invoke a menu command without first opening the popup. Expose each entry as a zero-size, never-painted child component carrying a menuItem handler - a leaf invokes its command on press, a submenu owner is a focus container holding its entries (recursing). The platform backends then present the menu tree through the standard roles/actions (AT-SPI menu item + action; UIA MenuItem + Invoke/ExpandCollapse; NSAccessibility) with no per-backend code. Entries refresh on menuItemsChanged so menus stay current.
juce_gui_basics has no accessibility implementation on Linux: the generic juce_Accessibility.cpp compiles an empty stub, so the AccessibilityHandler tree that JUCE already maintains is invisible to assistive technologies and UI automation tools. This adds a native backend that exposes that tree as AT-SPI 2 objects over D-Bus (direct D-Bus, as Qt does; not ATK). - No new dependencies: libdbus is loaded with dlopen and its (ABI-stable) types are declared locally, matching how juce_gui_basics treats its other optional Linux libraries. - All bus traffic is handled on the message thread: the bus socket fd is added to the event loop via LinuxEventLoop::registerFdCallback, so the connection is pumped on read-readiness with no polling, no extra thread and no locking. - One fallback object serves the whole /org/a11y/atspi subtree. Implemented interfaces: Accessible, Component, Application, Action, Value, Selection, Table, TableCell, Text, EditableText, Cache, the freedesktop Properties and Introspectable interfaces, plus AT-SPI event signals (state/children/bounds/ text/value changes, focus and window events). - Component.GetAccessibleAtPoint hit-testing (via AccessibilityHandler:: getChildAt), canonical role names from GetRoleName, the Selection interface derived from the children's selected/selectable states (mirroring the UIA SelectionProvider), and postAnnouncement emitting the AT-SPI live-region Announcement signal (at-spi2-core >= 2.46). Tested on Ubuntu 24.04 (at-spi2-core 2.52) with busctl and a libatspi client driving a running application: tree walking with roles/names/states/bounds, coordinate-free invocation via Action.DoAction, hit-testing, value get/set, and Cache.GetItems.
269bd17 to
8e1384c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
juce_gui_basics has no accessibility implementation on Linux: the generic juce_Accessibility.cpp compiles an empty stub, so the AccessibilityHandler tree that JUCE already maintains is invisible to assistive technologies and UI automation tools. This adds a native backend that exposes that tree as AT-SPI 2 objects over D-Bus (direct D-Bus, as Qt does; not ATK).
Tested on Ubuntu 24.04 (at-spi2-core 2.52) with busctl and a libatspi client driving a running application: tree walking with roles/names/states/bounds, coordinate-free invocation via Action.DoAction, value get/set, and Cache.GetItems.
Thank you for submitting a pull request.
Please make sure you have read and followed our contribution guidelines (.github/contributing.md in this repository). Your pull request will not be accepted if you have not followed the instructions.