Use lowercase dbghelp include for MinGW#1671
Open
SethTenenbaum wants to merge 1 commit into
Open
Conversation
SethTenenbaum
force-pushed
the
codex/mingw-dbghelp-header-case
branch
from
8b2850a to
505c63d
Compare
|
Closing stale Codex branch PR during backlog cleanup. Branch/commits are retained if this needs to be reopened. |
Author
|
Ok, it was cross compiling, ran into an error, made that change and so I figured I would report it. If it's unhelpful, please disregard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change the Windows DbgHelp include in juce_core from
<Dbghelp.h>to<dbghelp.h>.Windows/MSVC header lookup is case-insensitive, but MinGW cross-compiles on case-sensitive filesystems provide this header as lowercase
dbghelp.h. This mirrors the existing lowercaseuiautomation.hinclude used elsewhere in JUCE.Verification
On Debian Trixie with
g++-mingw-w64-x86-64andmingw-w64-x86-64-dev:#include <Dbghelp.h>fails withfatal error: Dbghelp.h: No such file or directory#include <dbghelp.h>compiles successfully<windows.h>,<dbghelp.h>, and<uiautomation.h>compiles successfully withx86_64-w64-mingw32-g++-posix -std=c++17