Fix VST3 COM Ptr incorrect initialization in headless format (#1673)#1674
Open
vlerdf wants to merge 1 commit into
Open
Fix VST3 COM Ptr incorrect initialization in headless format (#1673)#1674vlerdf wants to merge 1 commit into
vlerdf wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a memory leak during headless VST3 scanning, as reported in #1673.
The VSTComSmartPtr host was incorrectly initialized with IncrementRef::yes, resulting in an incorrect reference count of 2. Changed it to IncrementRef::no to match the standard initialization behavior of other VST3 host context pointers in the codebase.
Fixes #1673.