refactor: add scratch-buffer to forward_simulation!

Co-authored-by: Copilot <copilot@github.com>

Author: jucheval

src/simulate.jl

@@ -50,9 +50,10 @@ function rand(
 
     output = Matrix{Bool}(undef, N, T)
     current_value = stationary_initial_condition(modelconnec, excitatory)
+    past_value = similar(current_value)
     output[:, 1] = current_value
     for t in 1:(T - 1)
-        forward_simulation!(current_value, modelconnec, excitatory)
+        forward_simulation!(current_value, past_value, modelconnec, excitatory)
         output[:, t + 1] = current_value
     end
     return DiscreteTimeData(output)
@@ -151,10 +152,11 @@ end
 
 function forward_simulation!(
     current_value::Vector{Bool},
+    past_value::Vector{Bool},
     modelconnec::MarkovChainConnectivity,
     excitatory::Vector{Bool},
 )
-    past_value = copy(current_value)
+    copyto!(past_value, current_value)
 
     model = modelconnec.model
     N = size(modelconnec)

test/simulate.jl

@@ -1,8 +1,10 @@
 @testset "simulate.jl" begin
     @test begin
         testvalue = [true, false, true, false]
+        buffer = similar(testvalue)
         MF.forward_simulation!(
             testvalue,
+            buffer,
             MF.MarkovChainConnectivity(MarkovChainModel(0.5, 0.5, 0.0), ones(Int, (4, 4))),
             [true, false, true, false],
         )
@@ -11,19 +13,23 @@
 
     @test begin
         testvalue = [false, true, false, true]
+        buffer = similar(testvalue)
         MF.forward_simulation!(
             testvalue,
+            buffer,
             MF.MarkovChainConnectivity(MarkovChainModel(0, 0.5, 0.0), ones(Int, (4, 4))),
             [true, false, true, false],
         )
         testvalue == [false, false, false, false]
     end
 
     @test begin
-        modelconnec =
-            MF.MarkovChainConnectivity(MarkovChainModel(0.0, 0.0, 0.0), ones(Bool, 4, 4))
+        modelconnec = MF.MarkovChainConnectivity(
+            MarkovChainModel(0.0, 0.0, 0.0), ones(Bool, 4, 4)
+        )
         values, child, parent = MF.backward_step(collect(1:4), modelconnec)
-        all(i -> (haskey(values, i) || (i in child)), 1:4) && length(child) == length(parent)
+        all(i -> (haskey(values, i) || (i in child)), 1:4) &&
+            length(child) == length(parent)
     end
 
     @test begin