From c2e0e9f24768e1b764e76997f56d5b29aeecbb55 Mon Sep 17 00:00:00 2001 From: aditi-hinge Date: Tue, 30 Aug 2022 10:51:11 +0900 Subject: [PATCH 1/3] Row className typo fixed --- personal-portfolio/src/components/Banner.js | 85 ++++++++++++++------- 1 file changed, 58 insertions(+), 27 deletions(-) diff --git a/personal-portfolio/src/components/Banner.js b/personal-portfolio/src/components/Banner.js index a813a6b3d..cefae8e3f 100644 --- a/personal-portfolio/src/components/Banner.js +++ b/personal-portfolio/src/components/Banner.js @@ -1,17 +1,17 @@ import { useState, useEffect } from "react"; import { Container, Row, Col } from "react-bootstrap"; import headerImg from "../assets/img/header-img.svg"; -import { ArrowRightCircle } from 'react-bootstrap-icons'; -import 'animate.css'; -import TrackVisibility from 'react-on-screen'; +import { ArrowRightCircle } from "react-bootstrap-icons"; +import "animate.css"; +import TrackVisibility from "react-on-screen"; export const Banner = () => { const [loopNum, setLoopNum] = useState(0); const [isDeleting, setIsDeleting] = useState(false); - const [text, setText] = useState(''); + const [text, setText] = useState(""); const [delta, setDelta] = useState(300 - Math.random() * 100); const [index, setIndex] = useState(1); - const toRotate = [ "Web Developer", "Web Designer", "UI/UX Designer" ]; + const toRotate = ["Web Developer", "Web Designer", "UI/UX Designer"]; const period = 2000; useEffect(() => { @@ -19,59 +19,90 @@ export const Banner = () => { tick(); }, delta); - return () => { clearInterval(ticker) }; - }, [text]) + return () => { + clearInterval(ticker); + }; + }, [text]); const tick = () => { let i = loopNum % toRotate.length; let fullText = toRotate[i]; - let updatedText = isDeleting ? fullText.substring(0, text.length - 1) : fullText.substring(0, text.length + 1); + let updatedText = isDeleting + ? fullText.substring(0, text.length - 1) + : fullText.substring(0, text.length + 1); setText(updatedText); if (isDeleting) { - setDelta(prevDelta => prevDelta / 2); + setDelta((prevDelta) => prevDelta / 2); } if (!isDeleting && updatedText === fullText) { setIsDeleting(true); - setIndex(prevIndex => prevIndex - 1); + setIndex((prevIndex) => prevIndex - 1); setDelta(period); - } else if (isDeleting && updatedText === '') { + } else if (isDeleting && updatedText === "") { setIsDeleting(false); setLoopNum(loopNum + 1); setIndex(1); setDelta(500); } else { - setIndex(prevIndex => prevIndex + 1); + setIndex((prevIndex) => prevIndex + 1); } - } + }; return (
- + - {({ isVisible }) => -
- Welcome to my Portfolio -

{`Hi! I'm Judy`} {text}

-

Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book.

- -
} + {({ isVisible }) => ( +
+ Welcome to my Portfolio +

+ {`Hi! I'm Judy`}{" "} + + {text} + +

+

+ Lorem Ipsum is simply dummy text of the printing and + typesetting industry. Lorem Ipsum has been the industry's + standard dummy text ever since the 1500s, when an unknown + printer took a galley of type and scrambled it to make a + type specimen book. +

+ +
+ )}
- {({ isVisible }) => -
- Header Img -
} + {({ isVisible }) => ( +
+ Header Img +
+ )}
- ) -} + ); +}; From 775ecc52833ee801e3e734247913be60e0f865af Mon Sep 17 00:00:00 2001 From: aditi-hinge Date: Tue, 30 Aug 2022 10:54:05 +0900 Subject: [PATCH 2/3] link name changed from 'projects' to 'project' --- personal-portfolio/src/components/NavBar.js | 77 +++++++++++++++------ 1 file changed, 54 insertions(+), 23 deletions(-) diff --git a/personal-portfolio/src/components/NavBar.js b/personal-portfolio/src/components/NavBar.js index cce00e7d5..5cb399e49 100644 --- a/personal-portfolio/src/components/NavBar.js +++ b/personal-portfolio/src/components/NavBar.js @@ -1,17 +1,14 @@ import { useState, useEffect } from "react"; import { Navbar, Nav, Container } from "react-bootstrap"; -import logo from '../assets/img/logo.svg'; -import navIcon1 from '../assets/img/nav-icon1.svg'; -import navIcon2 from '../assets/img/nav-icon2.svg'; -import navIcon3 from '../assets/img/nav-icon3.svg'; -import { HashLink } from 'react-router-hash-link'; -import { - BrowserRouter as Router -} from "react-router-dom"; +import logo from "../assets/img/logo.svg"; +import navIcon1 from "../assets/img/nav-icon1.svg"; +import navIcon2 from "../assets/img/nav-icon2.svg"; +import navIcon3 from "../assets/img/nav-icon3.svg"; +import { HashLink } from "react-router-hash-link"; +import { BrowserRouter as Router } from "react-router-dom"; export const NavBar = () => { - - const [activeLink, setActiveLink] = useState('home'); + const [activeLink, setActiveLink] = useState("home"); const [scrolled, setScrolled] = useState(false); useEffect(() => { @@ -21,16 +18,16 @@ export const NavBar = () => { } else { setScrolled(false); } - } + }; window.addEventListener("scroll", onScroll); return () => window.removeEventListener("scroll", onScroll); - }, []) + }, []); const onUpdateActiveLink = (value) => { setActiveLink(value); - } + }; return ( @@ -44,23 +41,57 @@ export const NavBar = () => {
- - - + + + + + + + + +
- - + +
- ) -} + ); +}; From 7827d738c71833128f165bdf7b9864157a4e4317 Mon Sep 17 00:00:00 2001 From: aditi-hinge Date: Wed, 31 Aug 2022 15:19:22 +0900 Subject: [PATCH 3/3] typo fixed from 'section' to 'second' --- personal-portfolio/src/components/Projects.js | 114 +++++++++++------- 1 file changed, 69 insertions(+), 45 deletions(-) diff --git a/personal-portfolio/src/components/Projects.js b/personal-portfolio/src/components/Projects.js index 15f6b71e2..dc3377098 100644 --- a/personal-portfolio/src/components/Projects.js +++ b/personal-portfolio/src/components/Projects.js @@ -4,11 +4,10 @@ import projImg1 from "../assets/img/project-img1.png"; import projImg2 from "../assets/img/project-img2.png"; import projImg3 from "../assets/img/project-img3.png"; import colorSharp2 from "../assets/img/color-sharp2.png"; -import 'animate.css'; -import TrackVisibility from 'react-on-screen'; +import "animate.css"; +import TrackVisibility from "react-on-screen"; export const Projects = () => { - const projects = [ { title: "Business Startup", @@ -48,51 +47,76 @@ export const Projects = () => { - {({ isVisible }) => -
-

Projects

-

Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book.

- - - - - - { - projects.map((project, index) => { - return ( - - ) - }) - } - - - -

Lorem ipsum dolor sit amet consectetur adipisicing elit. Cumque quam, quod neque provident velit, rem explicabo excepturi id illo molestiae blanditiis, eligendi dicta officiis asperiores delectus quasi inventore debitis quo.

-
- -

Lorem ipsum dolor sit amet consectetur adipisicing elit. Cumque quam, quod neque provident velit, rem explicabo excepturi id illo molestiae blanditiis, eligendi dicta officiis asperiores delectus quasi inventore debitis quo.

-
-
-
-
} + {({ isVisible }) => ( +
+

Projects

+

+ Lorem Ipsum is simply dummy text of the printing and + typesetting industry. Lorem Ipsum has been the industry's + standard dummy text ever since the 1500s, when an unknown + printer took a galley of type and scrambled it to make a + type specimen book. +

+ + + + + + {projects.map((project, index) => { + return ; + })} + + + +

+ Lorem ipsum dolor sit amet consectetur adipisicing + elit. Cumque quam, quod neque provident velit, rem + explicabo excepturi id illo molestiae blanditiis, + eligendi dicta officiis asperiores delectus quasi + inventore debitis quo. +

+
+ +

+ Lorem ipsum dolor sit amet consectetur adipisicing + elit. Cumque quam, quod neque provident velit, rem + explicabo excepturi id illo molestiae blanditiis, + eligendi dicta officiis asperiores delectus quasi + inventore debitis quo. +

+
+
+
+
+ )}
- ) -} + ); +};