fix: evict memoized derived values when files are removed#110
Open
pfitzseb wants to merge 1 commit into
Open
Conversation
Removing a file only deleted its inputs; every derived value keyed by the URI (parse trees, diagnostics, testitems, ...) stayed in the Salsa storage for the lifetime of the workspace — measured at ~1.5 MB retained per removed file. Use the new Salsa.evict_derived! to drop all entries keyed by removed URIs in remove_file!, remove_all_children! (batched per call), and clear_indirect_file!. The promotion path in add_file! (indirect file becoming a regular file) deliberately does not evict: the URI stays live and its derived values revalidate through normal Salsa invalidation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing a file only deleted its inputs; every derived value keyed by the URI (parse trees, diagnostics, testitems, ...) stayed in the Salsa storage for the lifetime of the workspace — measured at ~1.5 MB retained per removed file. Use the new Salsa.evict_derived! to drop all entries keyed by removed URIs in remove_file!, remove_all_children! (batched per call), and clear_indirect_file!.
The promotion path in add_file! (indirect file becoming a regular file) deliberately does not evict: the URI stays live and its derived values revalidate through normal Salsa invalidation.
Requires julia-vscode/Salsa.jl#56.