Merge pull request #1105 from julia-vscode/sp/incremental-sync

Re-enable incremental sync and sync checking

Author: pfitzseb

src/requests/init.jl

@@ -4,10 +4,10 @@ function ServerCapabilities(client::ClientCapabilities)
     ServerCapabilities(
         TextDocumentSyncOptions(
             true,
-            TextDocumentSyncKinds.Full,
+            TextDocumentSyncKinds.Incremental,
             false,
             false,
-            SaveOptions(false)
+            SaveOptions(true)
         ),
         CompletionOptions(false, [".", "@", "\"", "^"], missing),
         true,

src/requests/textdocument.jl

@@ -42,9 +42,17 @@ function textDocument_didClose_notification(params::DidCloseTextDocumentParams,
 end
 
 function textDocument_didSave_notification(params::DidSaveTextDocumentParams, server::LanguageServerInstance, conn)
+    uri = params.textDocument.uri
+    doc = getdocument(server, uri)
+    if params.text isa String
+        if get_text(doc) != params.text
+            JSONRPC.send(conn, window_showMessage_notification_type, ShowMessageParams(MessageTypes.Error, "Julia Extension: Please contact us! Your extension just crashed with a bug that we have been trying to replicate for a long time. You could help the development team a lot by contacting us at https://github.com/julia-vscode/julia-vscode so that we can work together to fix this issue."))
+            throw(LSSyncMismatch("Mismatch between server and client text for $(get_uri(doc)). _open_in_editor is $(doc._open_in_editor). _workspace_file is $(doc._workspace_file). _version is $(get_version(doc))."))
+        end
+    end
+    parse_all(doc, server)
 end
 
-
 function textDocument_willSave_notification(params::WillSaveTextDocumentParams, server::LanguageServerInstance, conn)
 end