fix date '0000-00-00 00:00:00.000000' parse#228
Open
seanlook wants to merge 2 commits into
Open
Conversation
added 2 commits
August 30, 2017 10:13
to support handling datetime '0000-00-00' as string. affect datetime, datetime2, date. (not timestamp for now)
set 0 to '0000-00-00' rather than '1970-01-01 08:01:00'
|
any estimate of if/when this PR will be merged? It would be nice if I could chose how to handle the datetime. Thanks |
Collaborator
|
@the4thdoctor
|
|
Hi, yes the feature is still very needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it's because that the first microsecond part is skipped when it returns
Nonedate_tostrargument to BinLogStreamReader to decide the behavior.please refer issus datetime '0000-00-00' return string '0000-00-00' #225