Parse content type on userInfo Response to allow application/jwt;charset=UTF-8#479
Open
samuelwei wants to merge 2 commits into
Open
Parse content type on userInfo Response to allow application/jwt;charset=UTF-8#479samuelwei wants to merge 2 commits into
samuelwei wants to merge 2 commits into
Conversation
Collaborator
|
Unit tests please. THX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current implementation the content type of the userInfo Reponse must be exactly
application/jwtfor signed and/or encrypted responses. However the OpenID Connect certification system is usingapplication/jwt;charset=UTF-8- therefore the strict content type check fails, resulting in empty scopes.This PR extracts the content type and ignores the charset, so that the parsing of signed and/or encrypted responses is working again.
List of common tasks a pull request require complete