Skip to content

Fix diff_optimizer with no bridge#309

Merged
blegat merged 6 commits intomasterfrom
bl/no_bridge
Sep 7, 2025
Merged

Fix diff_optimizer with no bridge#309
blegat merged 6 commits intomasterfrom
bl/no_bridge

Conversation

@blegat
Copy link
Copy Markdown
Member

@blegat blegat commented Sep 6, 2025

Weirdly enough, it works after the first commit but fails once I remove the outer cache.
I think this is because POI first adds a quadratic constraint and then modifies it. Apparently it's not complaining if you have two layers of caches ?

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.01%. Comparing base (7953a55) to head (35f399e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #309   +/-   ##
=======================================
  Coverage   89.01%   89.01%           
=======================================
  Files          16       16           
  Lines        2057     2057           
=======================================
  Hits         1831     1831           
  Misses        226      226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blegat blegat merged commit 3b29d7f into master Sep 7, 2025
6 checks passed
@blegat blegat deleted the bl/no_bridge branch September 7, 2025 06:42
@blegat blegat mentioned this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant