Remove GC during Highs_run#345
Closed
odow wants to merge 1 commit into
Closed
Conversation
Member
Author
|
So this is arguably just a thread-safety bug in HiGHS: ERGO-Code/HiGHS#3136 (comment) Maybe we don't need any change here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 1600 1597 -3
=========================================
- Hits 1600 1597 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Closing because this was just a bug in HiGHS. The GC thing can still be useful because we don't call back into HiGHS for simplex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not thread-safe to call
Highs_destoryduringHighs_run: ERGO-Code/HiGHS#3136 (comment)This was originally added by #178. The original motivation isn't needed anymore, because we have a default callback the re-enters Julia to handle interrupts etc.
This might still not fix the thread-safety issue; that might need some changes in HiGHS itself.