Skip to content

Remove GC during Highs_run#345

Closed
odow wants to merge 1 commit into
masterfrom
odow-patch-1
Closed

Remove GC during Highs_run#345
odow wants to merge 1 commit into
masterfrom
odow-patch-1

Conversation

@odow

@odow odow commented Jul 7, 2026

Copy link
Copy Markdown
Member

It is not thread-safe to call Highs_destory during Highs_run: ERGO-Code/HiGHS#3136 (comment)

This was originally added by #178. The original motivation isn't needed anymore, because we have a default callback the re-enters Julia to handle interrupts etc.

This might still not fix the thread-safety issue; that might need some changes in HiGHS itself.

@odow

odow commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

So this is arguably just a thread-safety bug in HiGHS: ERGO-Code/HiGHS#3136 (comment)

Maybe we don't need any change here.

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (5f3e3b7) to head (1285731).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #345   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines         1600      1597    -3     
=========================================
- Hits          1600      1597    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow

odow commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

Closing because this was just a bug in HiGHS. The GC thing can still be useful because we don't call back into HiGHS for simplex.

@odow odow closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant