RFC: Refactor moi_function and jump_function into separate file#4190
Open
odow wants to merge 1 commit into
Open
RFC: Refactor moi_function and jump_function into separate file#4190odow wants to merge 1 commit into
odow wants to merge 1 commit into
Conversation
odow
commented
Jul 1, 2026
| function MOI.submit(model::GenericModel, cb::MOI.UserCut, con::ScalarConstraint) | ||
| return MOI.submit(backend(model), cb, moi_function(con.func), con.set) | ||
| f = moi_function(model, con.func) | ||
| return MOI.submit(backend(model), cb, f, con.set) |
odow
commented
Jul 1, 2026
| check_belongs_to_model(f, model) | ||
| return moi_function(f) | ||
| end | ||
|
|
Member
Author
There was a problem hiding this comment.
So this is a very weird method. It's not just a fallback. I think the only reason it was needed was because of check_belongs_to_model?
odow
commented
Jul 1, 2026
| name::String = "", | ||
| ) | ||
| con = model_convert(model, con) | ||
| check_belongs_to_model(con, model) |
Member
Author
There was a problem hiding this comment.
We just do it explicitly here now instead.
odow
commented
Jul 1, 2026
|
|
||
| # A default fallback for backwards compatibility. The first argument `model` was | ||
| # introduced in JuMP@1.31.0. | ||
| moi_function(model, f) = moi_function(f) |
Member
Author
There was a problem hiding this comment.
And now I have a much more sensible fallback.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## od/restore-moi-function #4190 +/- ##
===========================================================
- Coverage 99.93% 99.85% -0.08%
===========================================================
Files 42 43 +1
Lines 6277 6276 -1
===========================================================
- Hits 6273 6267 -6
- Misses 4 9 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x-ref #4189
We don't necessarily need to merge this. But these functions were spread all over the place. I'll comment in-line on something.