Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 98.85% 98.34% -0.52%
==========================================
Files 9 9
Lines 960 966 +6
==========================================
+ Hits 949 950 +1
- Misses 11 16 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
TV is not supposed to try to solve infeasible problems and KS is not supposed to as well in the second stage if the first stage is feasible |
|
Sure, we don't expect these to be infeasible. But the solvers can fail for any number of reasons. Iteration limits, numerical error, network license validation errors. |
|
I agree they should be there. I cannot think of a test case that will enable coverage, though. |
Yeah, I need to come up with something like "a solver that errors on the 5th solve"... |
|
Merged as an improvement. I'll think about how to test solve failures |
Closes #122