Add time limits to compute ideal point & dichotomy starting solutions#99
Merged
odow merged 4 commits intojump-dev:masterfrom Apr 8, 2025
Merged
Add time limits to compute ideal point & dichotomy starting solutions#99odow merged 4 commits intojump-dev:masterfrom
odow merged 4 commits intojump-dev:masterfrom
Conversation
with 0 timelimit, there should be no solutions as there is no solve.
Contributor
|
A time limit too small for the ideal point computation will probably also be too small to generate any nondominated points, right? |
odow
reviewed
Apr 7, 2025
odow
reviewed
Apr 7, 2025
odow
reviewed
Apr 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
==========================================
- Coverage 99.07% 98.77% -0.31%
==========================================
Files 9 9
Lines 974 980 +6
==========================================
+ Hits 965 968 +3
- Misses 9 12 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Oscar Dowson <odow@users.noreply.github.com>
Contributor
Author
Yeah, I think that would be the case in general. |
odow
approved these changes
Apr 8, 2025
Member
odow
left a comment
There was a problem hiding this comment.
Thanks! I'll merge this once CI runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds time limits to solving for ideal points, and the first solves of the dichotomy algorithm.
I realise that timing-out when solving for ideal points indicates that the time limit is probably way to small to get anything meaningful from the multi-objective formulation, but this was an edge case I faced, leading to some behaviour I was not expecting.
Also, this brings this package more in line with other MO solvers. For instance if I just used Gurobi to solve the multi-objective function, then for sure I would expect it to satisfy my time limit. But currently with this package the solver could go far beyond my time limit. For example, the start time before computation of ideal points is not passed down to any of the algorithms, so if it takes a long time to solve for ideal points, and the lower algorithm times out, then the overall solve time could be significantly more than the users time limit. But I haven't touched this because I users can now turn off ideal point calculation.
Hopefully that makes sense.
Finally, the logic before the 0 time limit unit-test for the dichotomy algorithm doesn't make sense to me. If the user provided a time limit of 0, then I would expect there to be no solutions returned?
Thanks for the package :)