Drop support for Julia 1.6 and make 1.10 the new minimum (#346)

Author: odow

.github/workflows/ci.yml

@@ -18,10 +18,10 @@ jobs:
         # MutableArithmetics doesn't have any binary dependencies, so just test
         # on Linux, LTS and current release, 64-bit and 32-bit.
         include:
-          - version: '1.6'
+          - version: '1.10'
             os: ubuntu-latest
             arch: x86
-          - version: '1.6'
+          - version: '1.10'
             os: ubuntu-latest
             arch: x64
           - version: '1'

.github/workflows/documentation.yml

@@ -12,7 +12,7 @@ jobs:
       - uses: actions/checkout@v6
       - uses: julia-actions/setup-julia@latest
         with:
-          version: '1.6'
+          version: '1.10'
       - name: Install dependencies
         run: julia --project=docs/ --color=yes -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()'
       - name: Build and deploy

.github/workflows/downstream.yml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        julia-version: ['1.6', '1']
+        julia-version: ['1.10', '1']
         os: ['ubuntu-latest']
         package:
           - {user: jump-dev, repo: JuMP.jl}

Project.toml

@@ -1,20 +1,20 @@
 name = "MutableArithmetics"
 uuid = "d8a4904e-b15c-11e9-3269-09a3773c0cb0"
-authors = ["Gilles Peiffer", "Benoît Legat", "Sascha Timme"]
 version = "1.6.7"
+authors = ["Gilles Peiffer", "Benoît Legat", "Sascha Timme"]
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
 SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [compat]
-LinearAlgebra = "<0.0.1, 1.6"
+LinearAlgebra = "1"
 OffsetArrays = "1"
-Random = "<0.0.1, 1.6"
-SparseArrays = "<0.0.1, 1.6"
-Test = "<0.0.1, 1.6"
-julia = "1.6"
+Random = "1"
+SparseArrays = "1"
+Test = "1"
+julia = "1.10"
 
 [extras]
 OffsetArrays = "6fe1bfb0-de20-5000-8ca7-80f57d26f881"

src/dispatch.jl

@@ -372,33 +372,30 @@ for f_A in _MatrixLike, f_B in vcat(_MatrixLike, T -> StridedVector{<:T})
     end
 end
 
-# See https://github.com/JuliaLang/julia/pull/37898
-# The default fallback only used `promote_type` so it may get its wrong, e.g.,
-# for JuMP and MultivariatePolynomials.
-if VERSION >= v"1.7.0-DEV.1284"
-    using LinearAlgebra: StridedMaybeAdjOrTransMat
-    _mat_mat_scalar(A, B, γ) = operate!!(*, operate(*, A, B), γ)
-    function LinearAlgebra.mat_mat_scalar(
-        A::StridedMaybeAdjOrTransMat{<:AbstractMutable},
-        B::StridedMaybeAdjOrTransMat,
-        γ,
-    )
-        return _mat_mat_scalar(A, B, γ)
-    end
-    function LinearAlgebra.mat_mat_scalar(
-        A::StridedMaybeAdjOrTransMat,
-        B::StridedMaybeAdjOrTransMat{<:AbstractMutable},
-        γ,
-    )
-        return _mat_mat_scalar(A, B, γ)
-    end
-    function LinearAlgebra.mat_mat_scalar(
-        A::StridedMaybeAdjOrTransMat{<:AbstractMutable},
-        B::StridedMaybeAdjOrTransMat{<:AbstractMutable},
-        γ,
-    )
-        return _mat_mat_scalar(A, B, γ)
-    end
+_mat_mat_scalar(A, B, γ) = operate!!(*, operate(*, A, B), γ)
+
+function LinearAlgebra.mat_mat_scalar(
+    A::LinearAlgebra.StridedMaybeAdjOrTransMat{<:AbstractMutable},
+    B::LinearAlgebra.StridedMaybeAdjOrTransMat,
+    γ,
+)
+    return _mat_mat_scalar(A, B, γ)
+end
+
+function LinearAlgebra.mat_mat_scalar(
+    A::LinearAlgebra.StridedMaybeAdjOrTransMat,
+    B::LinearAlgebra.StridedMaybeAdjOrTransMat{<:AbstractMutable},
+    γ,
+)
+    return _mat_mat_scalar(A, B, γ)
+end
+
+function LinearAlgebra.mat_mat_scalar(
+    A::LinearAlgebra.StridedMaybeAdjOrTransMat{<:AbstractMutable},
+    B::LinearAlgebra.StridedMaybeAdjOrTransMat{<:AbstractMutable},
+    γ,
+)
+    return _mat_mat_scalar(A, B, γ)
 end
 
 # Base doesn't define efficient fallbacks for sparse array arithmetic involving
@@ -614,18 +611,6 @@ end
 # the type by default.
 Base.zero(x::AbstractMutable) = zero(typeof(x))
 
-# This was fixed in https://github.com/JuliaLang/julia/pull/36194 but then
-# reverted. Fixed again in https://github.com/JuliaLang/julia/pull/38789/.
-if VERSION >= v"1.7.0-DEV.872"
-    # `AbstractMutable` objects are more likely to implement `iszero` than `==`
-    # with `Int`.
-    LinearAlgebra.iszerodefined(::Type{<:AbstractMutable}) = true
-else
-    # To determine whether the funtion is zero preserving, `LinearAlgebra` calls
-    # `zero` on the `eltype` of the broadcasted object and then check `_iszero`.
-    # `_iszero(x)` redirects to `iszero(x)` for numbers and to `x == 0`
-    # otherwise.
-    # `x == 0` returns false for types that implement `iszero` but not `==` such
-    # as `DummyBigInt` and MOI functions.
-    LinearAlgebra._iszero(x::AbstractMutable) = iszero(x)
-end
+# `AbstractMutable` objects are more likely to implement `iszero` than `==`
+# with `Int`.
+LinearAlgebra.iszerodefined(::Type{<:AbstractMutable}) = true