Update CI jobs, add Dependabot, update JuliaFormatter (#345)

Author: odow

.github/dependabot.yml

@@ -0,0 +1,7 @@
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/" # Location of package manifests
+    schedule:
+      interval: "weekly"

.github/workflows/aqua.yml

@@ -12,7 +12,7 @@ jobs:
       - uses: julia-actions/setup-julia@latest
         with:
           version: '1'
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
       - name: Aqua
         shell: julia --color=yes {0}
         run: |

.github/workflows/ci.yml

@@ -31,16 +31,16 @@ jobs:
             os: ubuntu-latest
             arch: x64
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - uses: julia-actions/setup-julia@v2
         with:
           version: ${{ matrix.version }}
           arch: ${{ matrix.arch }}
-      - uses: julia-actions/cache@v1
+      - uses: julia-actions/cache@v2
       - uses: julia-actions/julia-buildpkg@v1
       - uses: julia-actions/julia-runtest@v1
       - uses: julia-actions/julia-processcoverage@v1
-      - uses: codecov/codecov-action@v4
+      - uses: codecov/codecov-action@v5
         with:
-          file: lcov.info
+          files: lcov.info
           token: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/documentation.yml

@@ -9,7 +9,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
       - uses: julia-actions/setup-julia@latest
         with:
           version: '1.6'

.github/workflows/downstream.yml

@@ -15,14 +15,14 @@ jobs:
         package:
           - {user: jump-dev, repo: JuMP.jl}
     steps:
-      - uses: actions/checkout@v3
-      - uses: julia-actions/setup-julia@v1
+      - uses: actions/checkout@v6
+      - uses: julia-actions/setup-julia@v2
         with:
           version: ${{ matrix.julia-version }}
           arch: x64
       - uses: julia-actions/julia-buildpkg@latest
       - name: Clone Downstream
-        uses: actions/checkout@v3
+        uses: actions/checkout@v6
         with:
           repository: ${{ matrix.package.user }}/${{ matrix.package.repo }}
           path: downstream

.github/workflows/format_check.yml

@@ -13,13 +13,13 @@ jobs:
       - uses: julia-actions/setup-julia@latest
         with:
           version: '1'
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - name: Format check
         shell: julia --color=yes {0}
         run: |
           using Pkg
           # If you update the version, also update the style guide docs.
-          Pkg.add(PackageSpec(name="JuliaFormatter", version="1"))
+          Pkg.add(PackageSpec(name="JuliaFormatter", version="2"))
           using JuliaFormatter
           format(".", verbose=true)
           out = String(read(Cmd(`git diff`)))

src/implementations/SparseArrays.jl

@@ -242,7 +242,7 @@ function operate!(
                         QuickSort,
                         Base.Order.Forward,
                     )
-                    for vp in ip0:ip-1
+                    for vp in ip0:(ip-1)
                         k = ret.rowval[vp]
                         xb[k] = false
                         ret.nzval[vp] = ret.nzval[k+k0]

src/interface.jl

@@ -330,7 +330,7 @@ function _size_after_multiply(x::NTuple{M,Int}, y::NTuple{N,Int}) where {N,M}
     if x[end] != y[1]
         return nothing
     end
-    return (x[1:end-1]..., y[2:end]...)
+    return (x[1:(end-1)]..., y[2:end]...)
 end
 
 _size_after_multiply(::Tuple{}, rhs::NTuple{M,Int}) where {M} = rhs

test/interface.jl

@@ -228,7 +228,7 @@ end
 
 @testset "issue_316_SubArray" begin
     y = reshape([1.0], 1, 1, 1)
-    Y = view(y, :, :, 1)
+    Y = view(y,:,:,1)
     ret = reshape([1.0], 1, 1)
     ret = MA.operate!!(MA.add_mul, ret, 2.0, Y)
     @test ret == reshape([3.0], 1, 1)

test/rewrite.jl

@@ -166,7 +166,7 @@ Base.getindex(x::_KwargRef; i) = x.data[i]
 
 @testset "test_rewrite_kw_in_ref" begin
     x = _KwargRef(Dict(i => i + 1 for i in 2:4))
-    @test MA.@rewrite(sum(x[i = j] for j in 2:4)) == 12
+    @test MA.@rewrite(sum(x[i=j] for j in 2:4)) == 12
 end
 
 @testset "dispatch_dot" begin