Skip to content

Fix tests for Julia v1.11 and later#314

Merged
odow merged 20 commits into
masterfrom
od/nightly
May 16, 2025
Merged

Fix tests for Julia v1.11 and later#314
odow merged 20 commits into
masterfrom
od/nightly

Conversation

@odow
Copy link
Copy Markdown
Member

@odow odow commented Nov 17, 2024

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (eccbd5f) to head (c116d8b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   90.36%   90.50%   +0.13%     
==========================================
  Files          22       22              
  Lines        2253     2253              
==========================================
+ Hits         2036     2039       +3     
+ Misses        217      214       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odow
Copy link
Copy Markdown
Member Author

odow commented Nov 17, 2024

Ugh. Tests pass locally on nightly. But not on CI...

Comment thread test/broadcast.jl Outdated
@odow
Copy link
Copy Markdown
Member Author

odow commented Nov 17, 2024

I think there's something deeper at play. Hard to replicate because I don't see these numbers locally?

@blegat
Copy link
Copy Markdown
Member

blegat commented Jan 13, 2025

I don't know if it's worth debugging nightly if it's not yet a release candidate

@odow odow changed the title Relax allocation tests on nightly Fix tests for Julia v1.11 and later May 16, 2025
@odow odow merged commit e470c6b into master May 16, 2025
11 checks passed
@odow odow deleted the od/nightly branch May 16, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants