Conversation
odow
reviewed
Jul 7, 2025
* add ParametricVectorQuadraticFunction * use at_variable and remove unecessary calls * start addressing variable coefficients * update tests * fix bugs * fix bug * update add constraint * update test * update jump test * fix test * rm update * update add_constraint * attemp replace * update functions * update * update * working first set * update tol * update tol * finish * change tests names * Apply suggestions from code review --------- Co-authored-by: Joaquim <joaquimdgarcia@gmail.com>
* fix VariablePrimalStart * add get VariablePrimalStart * fix "is_valid" * fix ambiguity * format --------- Co-authored-by: joaquimg <joaquimdgarcia@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 97.15% 97.51% +0.35%
==========================================
Files 5 5
Lines 1161 1449 +288
==========================================
+ Hits 1128 1413 +285
- Misses 33 36 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* fix VariablePrimalStart * add get VariablePrimalStart * fix "is_valid" * fix ambiguity * format * add more vector tests --------- Co-authored-by: Andrew <arosemberg3@gatech.edu>
* fix key vector quadratic * add new tests and fix affine cache * format * test constraint name set and get * add no parameter problem * fix test name * fix comment * force has_parameter and !_is_vector_affine * update coverage * remove useless function * update tests coverage * format and rm useless functions * improve tests to force coverage improvement * fix typo
Merged
* update tests and coverage * update tests * update tests * add copy to test * fix typo * format * fix typo
Merged
* improve coverage 2.0 * format * fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanup support for constrained variablesnow Review support for constrained variables #180