Add hability to query duals of multiplicative parameters in parameter…#171
Add hability to query duals of multiplicative parameters in parameter…#171
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 95.80% 96.57% +0.76%
==========================================
Files 5 5
Lines 1097 1109 +12
==========================================
+ Hits 1051 1071 +20
+ Misses 46 38 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Also, check codecov |
| pf::ParametricAffineFunction{T}, | ||
| ci::MOI.ConstraintIndex{F,S}, | ||
| ) where {F,S} where {T} | ||
| ) where {F,S} where {T, OT} |
There was a problem hiding this comment.
I think OT is not needed in any of these methods.
T is important to gave matching types.
There was a problem hiding this comment.
unfortunately OT is needed because the optimizer has two types inside.
ParametricOptInterface.Optimizer{Float64, GLPK.Optimizer}T catches the Float64 and OT catches the solver.
| uuid = "0ce4ce61-57bf-432b-a095-efac525d185e" | ||
| authors = ["Tomás Gutierrez <tomasfmgutierrez@gmail.com>"] | ||
| version = "0.9.0" | ||
| version = "0.10.0" |
There was a problem hiding this comment.
If this is a new feature, it should be 0.9.1. If this is breaking, it should be 0.10.0
There was a problem hiding this comment.
Honestly, you could also see it as either one or the other. I tended to the breaking change bump because before the behavior was an error and now it is allowed. It is not something that did not exist in the package and now it is implemented. It was explicitly prohibited.
4 participants
… * parameter terms