Add validation so that parameters cannot be NaN#173
Merged
guilhermebodin merged 5 commits intomasterfrom Apr 3, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
==========================================
+ Coverage 95.80% 96.58% +0.78%
==========================================
Files 5 5
Lines 1097 1114 +17
==========================================
+ Hits 1051 1076 +25
+ Misses 46 38 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joaquimg
reviewed
Apr 3, 2025
| end | ||
|
|
||
| function _assert_parameter_is_not_nan(set::MOI.Parameter{T}) where {T} | ||
| if isnan(set.value) |
Member
There was a problem hiding this comment.
Lets switch to "isfinite" that checks both NaN and Inf?
Collaborator
Author
There was a problem hiding this comment.
I was wondering if Inf was a valid parameter. But ok I will change it
Member
There was a problem hiding this comment.
I was thinking the same, but since JuMP blocks this, we should block as well
Member
There was a problem hiding this comment.
is someone shows up with a use case, we can review
joaquimg
reviewed
Apr 3, 2025
joaquimg
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.