Skip to content

Commit 018adaa

Browse files
committed
use effective_duration
Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
1 parent 1c25bc5 commit 018adaa

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

python/packages/jumpstarter/jumpstarter/client/lease.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ def _notify_lease_ending(self, remaining: timedelta) -> None:
289289

290290
def _get_lease_end_time(self, lease) -> datetime | None:
291291
"""Extract the end time from a lease response, or None if not available."""
292-
if not (lease.effective_begin_time and lease.effective_duration):
292+
if not (lease.effective_begin_time and lease.duration):
293293
return None
294294
if lease.effective_end_time:
295295
return lease.effective_end_time

python/packages/jumpstarter/jumpstarter/client/lease_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -396,15 +396,15 @@ def _make_lease(self):
396396

397397
def test_returns_none_when_no_begin_time(self):
398398
lease = self._make_lease()
399-
response = Mock(effective_begin_time=None, effective_duration=timedelta(minutes=30))
399+
response = Mock(effective_begin_time=None, duration=timedelta(minutes=30))
400400

401401
assert lease._get_lease_end_time(response) is None
402402

403403
def test_returns_none_when_no_duration(self):
404404
lease = self._make_lease()
405405
response = Mock(
406406
effective_begin_time=datetime.now(tz=timezone.utc),
407-
effective_duration=None,
407+
duration=None,
408408
)
409409

410410
assert lease._get_lease_end_time(response) is None
@@ -414,7 +414,7 @@ def test_returns_effective_end_time_when_present(self):
414414
end_time = datetime(2025, 6, 1, 12, 0, 0, tzinfo=timezone.utc)
415415
response = Mock(
416416
effective_begin_time=datetime(2025, 6, 1, 11, 0, 0, tzinfo=timezone.utc),
417-
effective_duration=timedelta(hours=1),
417+
duration=timedelta(hours=1),
418418
effective_end_time=end_time,
419419
)
420420

@@ -426,7 +426,7 @@ def test_calculates_end_time_when_no_effective_end(self):
426426
duration = timedelta(hours=2)
427427
response = Mock(
428428
effective_begin_time=begin,
429-
effective_duration=duration,
429+
effective_duration=timedelta(hours=1), # elapsed time, not used for calculation
430430
effective_end_time=None,
431431
duration=duration,
432432
)

0 commit comments

Comments
 (0)