fix: remove vestigial METHOD deployment abstraction

Since Helm support was removed, "operator" is the only deployment
method. Remove the METHOD variable, its branching logic, and the
parameterized print_deployment_success function throughout the
e2e scripts, CI workflows, and hack utilities.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: raballew

.github/workflows/e2e.yaml

@@ -59,13 +59,11 @@ jobs:
         run: make e2e-setup
         env:
           CI: true
-          METHOD: operator
 
       - name: Run e2e tests
         run: make e2e-run
         env:
           CI: true
-          METHOD: operator
 
   # ============================================================================
   # Compatibility tests: cross-version interop between controller and client/exporter

controller/hack/deploy_with_operator.sh

@@ -217,5 +217,5 @@ wait_for_jumpstarter_resources
 check_grpc_endpoints
 
 # Print success banner
-print_deployment_success "operator"
+print_deployment_success
 

controller/hack/utils

@@ -244,17 +244,8 @@ check_grpc_endpoints() {
 }
 
 # Print deployment success banner
-# Args:
-#   $1: deployment method (e.g., "operator") - optional
 print_deployment_success() {
-  local method=${1:-""}
-  local method_text=""
-  
-  if [ -n "${method}" ]; then
-    method_text=" via ${method}"
-  fi
-  
-  echo -e "${GREEN}Jumpstarter controller deployed successfully${method_text}!${NC}"
+  echo -e "${GREEN}Jumpstarter controller deployed successfully!${NC}"
   echo -e " gRPC        endpoint: ${GRPC_ENDPOINT}"
   echo -e " gRPC router endpoint: ${GRPC_ROUTER_ENDPOINT}"
 }

e2e/compat/setup.sh

@@ -24,8 +24,6 @@ REPO_ROOT="$(cd "$E2E_DIR/.." && pwd)"
 # Default namespace for tests
 export JS_NAMESPACE="${JS_NAMESPACE:-jumpstarter-lab}"
 
-export METHOD="operator"
-
 # Scenario configuration
 COMPAT_SCENARIO="${COMPAT_SCENARIO:-old-controller}"
 COMPAT_CONTROLLER_TAG="${COMPAT_CONTROLLER_TAG:-v0.7.0}"
@@ -312,7 +310,6 @@ ENDPOINT=$ENDPOINT
 JS_NAMESPACE=$JS_NAMESPACE
 REPO_ROOT=$REPO_ROOT
 SCRIPT_DIR=$SCRIPT_DIR
-METHOD=$METHOD
 BATS_LIB_PATH=${BATS_LIB_PATH:-}
 EOF
 

e2e/setup-e2e.sh

@@ -13,9 +13,6 @@ REPO_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)"
 # Default namespace for tests
 export JS_NAMESPACE="${JS_NAMESPACE:-jumpstarter-lab}"
 
-# Deployment method
-export METHOD="${METHOD:-operator}"
-
 # Color output
 RED='\033[0;31m'
 GREEN='\033[0;32m'
@@ -264,7 +261,7 @@ deploy_dex() {
 
 # Step 3: Deploy jumpstarter controller
 deploy_controller() {
-    log_info "Deploying jumpstarter controller (method: $METHOD)..."
+    log_info "Deploying jumpstarter controller..."
 
     cd "$REPO_ROOT"
 
@@ -322,8 +319,6 @@ setup_test_environment() {
     echo "JS_NAMESPACE=$JS_NAMESPACE" >> "$REPO_ROOT/.e2e-setup-complete"
     echo "REPO_ROOT=$REPO_ROOT" >> "$REPO_ROOT/.e2e-setup-complete"
     echo "SCRIPT_DIR=$SCRIPT_DIR" >> "$REPO_ROOT/.e2e-setup-complete"
-    echo "METHOD=$METHOD" >> "$REPO_ROOT/.e2e-setup-complete"
-    
     # Set SSL certificate paths for Python to use the generated CA
     echo "SSL_CERT_FILE=$REPO_ROOT/ca.pem" >> "$REPO_ROOT/.e2e-setup-complete"
     echo "REQUESTS_CA_BUNDLE=$REPO_ROOT/ca.pem" >> "$REPO_ROOT/.e2e-setup-complete"
@@ -338,7 +333,6 @@ setup_test_environment() {
 main() {
     log_info "=== Jumpstarter E2E Setup ==="
     log_info "Namespace: $JS_NAMESPACE"
-    log_info "Deployment Method: $METHOD"
     log_info "Repository Root: $REPO_ROOT"
     log_info "Script Directory: $SCRIPT_DIR"
     echo ""

e2e/tests.bats

@@ -284,11 +284,6 @@ _wait_for_single_exporter() {
 }
 
 @test "can login with simplified login" {
-  # This test only works with operator-based deployment, which deploys the CA ConfigMap
-  if [ "${METHOD:-}" != "operator" ]; then
-    skip "CA certificate injection only configured with operator deployment (METHOD=$METHOD)"
-  fi
-
   jmp config client   delete test-client-oidc
 
   run jmp login test-client-oidc@http://${LOGIN_ENDPOINT} --insecure-tls --nointeractive \
@@ -351,11 +346,6 @@ EOF
 }
 
 @test "legacy client config contains CA certificate and works with secure TLS" {
-  # This test only works with operator-based deployment, which creates the CA ConfigMap
-  if [ "${METHOD:-}" != "operator" ]; then
-    skip "CA certificate injection only available with operator deployment (METHOD=$METHOD)"
-  fi
-
   wait_for_exporter
 
   # Get the config file path from jmp (clients are saved to ~/.config/jumpstarter/clients/)