fix: remove old-controller compat test (v0.7.0 has no operator installer)

v0.7.0 predates the monorepo merge and was only deployable via OCI Helm
chart. With Helm fully removed, the old-controller compat test cannot
deploy a v0.7.0 controller. Remove the test, its CI job, and simplify
the compat infrastructure to only support the old-client scenario.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: raballew

.github/workflows/e2e.yaml

@@ -65,39 +65,6 @@ jobs:
         env:
           CI: true
 
-  # ============================================================================
-  # Compatibility tests: cross-version interop between controller and client/exporter
-  # These jobs can be removed once 0.7.x controller support is no longer needed.
-  # ============================================================================
-
-  e2e-compat-old-controller:
-    needs: changes
-    if: needs.changes.outputs.should_run == 'true' || github.event_name == 'workflow_dispatch'
-    runs-on: ubuntu-24.04
-    timeout-minutes: 60
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
-      - name: Install uv
-        uses: astral-sh/setup-uv@v7
-
-      - name: Install Go
-        uses: actions/setup-go@v5
-        with:
-          go-version: "1.22"
-
-      - name: Setup compat environment (old controller v0.7.0)
-        run: make e2e-compat-setup COMPAT_SCENARIO=old-controller
-        env:
-          CI: true
-          COMPAT_CONTROLLER_TAG: v0.7.0
-
-      - name: Run compat tests (old controller + new client/exporter)
-        run: make e2e-compat-run COMPAT_TEST=old-controller
-        env:
-          CI: true
-
   e2e-compat-old-client:
     needs: changes
     if: needs.changes.outputs.should_run == 'true' || github.event_name == 'workflow_dispatch'
@@ -115,13 +82,13 @@ jobs:
         with:
           go-version: "1.22"
 
-      - name: Setup compat environment (old client v0.7.0)
-        run: make e2e-compat-setup COMPAT_SCENARIO=old-client
+      - name: Setup compat environment (old client v0.7.1)
+        run: make e2e-compat-setup
         env:
           CI: true
           COMPAT_CLIENT_VERSION: "0.7.1"
 
       - name: Run compat tests (new controller + old client/exporter)
-        run: make e2e-compat-run COMPAT_TEST=old-client
+        run: make e2e-compat-run
         env:
           CI: true

Makefile

@@ -164,21 +164,17 @@ e2e-clean:
 test-e2e: e2e-run
 
 # Compatibility E2E testing (cross-version tests, separate from main e2e)
-COMPAT_SCENARIO ?= old-controller
-COMPAT_TEST ?= old-controller
-COMPAT_CONTROLLER_TAG ?= v0.7.0
 COMPAT_CLIENT_VERSION ?= 0.7.1
 
 .PHONY: e2e-compat-setup
 e2e-compat-setup:
-	@echo "Setting up compat e2e (scenario: $(COMPAT_SCENARIO))..."
-	@COMPAT_SCENARIO=$(COMPAT_SCENARIO) COMPAT_CONTROLLER_TAG=$(COMPAT_CONTROLLER_TAG) \
-	 COMPAT_CLIENT_VERSION=$(COMPAT_CLIENT_VERSION) bash e2e/compat/setup.sh
+	@echo "Setting up compat e2e (old client v$(COMPAT_CLIENT_VERSION))..."
+	@COMPAT_CLIENT_VERSION=$(COMPAT_CLIENT_VERSION) bash e2e/compat/setup.sh
 
 .PHONY: e2e-compat-run
 e2e-compat-run:
-	@echo "Running compat e2e (test: $(COMPAT_TEST))..."
-	@COMPAT_TEST=$(COMPAT_TEST) bash e2e/compat/run.sh
+	@echo "Running compat e2e (old client)..."
+	@COMPAT_TEST=old-client bash e2e/compat/run.sh
 
 # Per-project clean targets
 .PHONY: clean-python clean-protocol clean-controller clean-e2e

e2e/compat/run.sh

@@ -3,7 +3,7 @@
 # This script runs the compatibility test suite (assumes setup.sh was run first)
 #
 # Environment variables:
-#   COMPAT_TEST - Which test to run: "old-controller" or "old-client"
+#   COMPAT_TEST - Which test to run (default: "old-client")
 
 set -euo pipefail
 
@@ -90,21 +90,17 @@ run_tests() {
     # Setup bats environment
     setup_bats_env
 
-    COMPAT_TEST="${COMPAT_TEST:-old-controller}"
+    COMPAT_TEST="${COMPAT_TEST:-old-client}"
     log_info "Running compat test: $COMPAT_TEST"
 
     case "$COMPAT_TEST" in
-        old-controller)
-            bats -x --show-output-of-passing-tests --verbose-run \
-                "$SCRIPT_DIR/tests-old-controller.bats"
-            ;;
         old-client)
             export OLD_JMP
             bats -x --show-output-of-passing-tests --verbose-run \
                 "$SCRIPT_DIR/tests-old-client.bats"
             ;;
         *)
-            log_error "Unknown COMPAT_TEST: $COMPAT_TEST (expected 'old-controller' or 'old-client')"
+            log_error "Unknown COMPAT_TEST: $COMPAT_TEST (expected 'old-client')"
             exit 1
             ;;
     esac
@@ -115,7 +111,7 @@ main() {
     export JS_NAMESPACE="${JS_NAMESPACE:-jumpstarter-lab}"
 
     log_info "=== Jumpstarter Compatibility E2E Test Runner ==="
-    log_info "Test: ${COMPAT_TEST:-old-controller}"
+    log_info "Test: ${COMPAT_TEST:-old-client}"
     log_info "Namespace: $JS_NAMESPACE"
     log_info "Repository Root: $REPO_ROOT"
     echo ""

e2e/compat/setup.sh

@@ -6,8 +6,6 @@
 # Uses operator-based deployment.
 #
 # Environment variables:
-#   COMPAT_SCENARIO      - "old-controller" or "old-client" (required)
-#   COMPAT_CONTROLLER_TAG - Controller image tag for old-controller scenario (default: v0.7.0)
 #   COMPAT_CLIENT_VERSION - PyPI version for old-client scenario (default: 0.7.1)
 
 set -euo pipefail
@@ -24,9 +22,6 @@ REPO_ROOT="$(cd "$E2E_DIR/.." && pwd)"
 # Default namespace for tests
 export JS_NAMESPACE="${JS_NAMESPACE:-jumpstarter-lab}"
 
-# Scenario configuration
-COMPAT_SCENARIO="${COMPAT_SCENARIO:-old-controller}"
-COMPAT_CONTROLLER_TAG="${COMPAT_CONTROLLER_TAG:-v0.7.0}"
 COMPAT_CLIENT_VERSION="${COMPAT_CLIENT_VERSION:-0.7.1}"
 
 # Color output
@@ -167,17 +162,6 @@ install_dependencies() {
     log_info "Dependencies installed"
 }
 
-# Get the external IP for baseDomain
-get_external_ip() {
-    if which ip 2>/dev/null 1>/dev/null; then
-        ip route get 1.1.1.1 | grep -oP 'src \K\S+'
-    else
-        local INTERFACE
-        INTERFACE=$(route get 1.1.1.1 | grep interface | awk '{print $2}')
-        ifconfig | grep "$INTERFACE" -A 10 | grep "inet " | grep -Fv 127.0.0.1 | awk '{print $2}' | head -n 1
-    fi
-}
-
 # Create kind cluster and install grpcurl
 create_cluster() {
     log_info "Creating kind cluster..."
@@ -188,46 +172,6 @@ create_cluster() {
     log_info "Kind cluster created"
 }
 
-deploy_old_controller() {
-    log_info "Deploying old controller (version: $COMPAT_CONTROLLER_TAG)..."
-
-    cd "$REPO_ROOT"
-
-    # Compute networking variables
-    local IP
-    IP=$(get_external_ip)
-    BASEDOMAIN="jumpstarter.${IP}.nip.io"
-    GRPC_ENDPOINT="grpc.${BASEDOMAIN}:8082"
-    GRPC_ROUTER_ENDPOINT="router.${BASEDOMAIN}:8083"
-
-    kubectl config use-context kind-jumpstarter
-
-    # Install old controller using operator installer from the release tag
-    local INSTALLER_URL="https://raw.githubusercontent.com/jumpstarter-dev/jumpstarter/${COMPAT_CONTROLLER_TAG}/controller/deploy/operator/dist/install.yaml"
-    log_info "Installing old controller via operator (version: ${COMPAT_CONTROLLER_TAG})..."
-    kubectl apply -f "${INSTALLER_URL}" || log_warn "Operator installer may not be available for ${COMPAT_CONTROLLER_TAG}, skipping"
-
-    kubectl config set-context --current --namespace=jumpstarter-lab
-
-    # Wait for gRPC endpoints
-    local GRPCURL="${REPO_ROOT}/controller/bin/grpcurl"
-    log_info "Waiting for gRPC endpoints..."
-    for ep in ${GRPC_ENDPOINT} ${GRPC_ROUTER_ENDPOINT}; do
-        local retries=60
-        log_info "  Checking ${ep}..."
-        while ! ${GRPCURL} -insecure "${ep}" list > /dev/null 2>&1; do
-            sleep 2
-            retries=$((retries - 1))
-            if [ ${retries} -eq 0 ]; then
-                log_error "${ep} not ready after 120s"
-                exit 1
-            fi
-        done
-    done
-
-    log_info "Old controller deployed"
-}
-
 deploy_new_controller() {
     log_info "Deploying new controller from HEAD..."
 
@@ -324,7 +268,7 @@ EOF
 # Main execution
 main() {
     log_info "=== Jumpstarter Compatibility E2E Setup ==="
-    log_info "Scenario: $COMPAT_SCENARIO"
+    log_info "Scenario: New Controller + Old Client/Exporter ($COMPAT_CLIENT_VERSION)"
     log_info "Namespace: $JS_NAMESPACE"
     log_info "Repository Root: $REPO_ROOT"
     echo ""
@@ -335,34 +279,20 @@ main() {
     create_cluster
     echo ""
 
-    case "$COMPAT_SCENARIO" in
-        old-controller)
-            log_info "Scenario: Old Controller ($COMPAT_CONTROLLER_TAG) + New Client/Exporter"
-            deploy_old_controller
-            echo ""
-            install_jumpstarter
-            ;;
-        old-client)
-            log_info "Scenario: New Controller + Old Client/Exporter ($COMPAT_CLIENT_VERSION)"
-            deploy_new_controller
-            echo ""
-            install_jumpstarter
-            echo ""
-            install_old_client
-            ;;
-        *)
-            log_error "Unknown COMPAT_SCENARIO: $COMPAT_SCENARIO (expected 'old-controller' or 'old-client')"
-            exit 1
-            ;;
-    esac
+    deploy_new_controller
+    echo ""
+
+    install_jumpstarter
+    echo ""
+
+    install_old_client
     echo ""
 
     setup_test_environment
     echo ""
 
     log_info "=== Compat setup complete! ==="
-    log_info "Scenario: $COMPAT_SCENARIO"
-    log_info "To run tests: make e2e-compat-run COMPAT_TEST=<old-controller|old-client>"
+    log_info "To run tests: make e2e-compat-run COMPAT_TEST=old-client"
 }
 
 main "$@"

e2e/compat/tests-old-client.bats

@@ -21,7 +21,7 @@ setup_file() {
   # Verify OLD_JMP is set and exists
   if [ -z "$OLD_JMP" ] || [ ! -x "$OLD_JMP" ]; then
     echo "ERROR: OLD_JMP not set or not executable: '$OLD_JMP'" >&2
-    echo "Please run setup.sh with COMPAT_SCENARIO=old-client first." >&2
+    echo "Please run setup.sh first." >&2
     exit 1
   fi