Commit ab7da1d
nanokvm: address review feedback and remove dead serial/SSH code
- Extract NanoKVMDriverBase to deduplicate client management across
NanoKVMVideo and NanoKVMHID (~30 lines of copy-paste removed)
- Remove NanoKVMSerial placeholder class and all SSH/serial config
(enable_serial, ssh_username, ssh_password, ssh_port)
- Fix stream re-auth bug: keep send_stream context open during retry
so the retry can still write to the stream
- Replace asyncio.create_task with anyio.create_task_group for
consistency with project conventions
- Apply @with_reauth decorator directly on NanoKVM composite methods
instead of fragile inner-function pattern; delegate _get_client and
_reset_client to video child driver
- Fix mount_image unmount logic: pass None explicitly for unmount
instead of confusing `mount_file or None` expression
- Add pytest-asyncio to dev dependencies (needed for asyncio_mode=auto)
- Remove jumpstarter-driver-pyserial dependency (only needed for serial)
- Add get_images to API docs :members: list
- Remove serial/SSH references from README and documentation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent 97f2db1 commit ab7da1d
6 files changed
Lines changed: 104 additions & 277 deletions
File tree
- python/packages/jumpstarter-driver-nanokvm
- examples
- jumpstarter_driver_nanokvm
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | 44 | | |
62 | 45 | | |
63 | 46 | | |
64 | 47 | | |
65 | 48 | | |
66 | 49 | | |
67 | 50 | | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | 51 | | |
73 | 52 | | |
74 | 53 | | |
75 | | - | |
| 54 | + | |
76 | 55 | | |
77 | 56 | | |
78 | 57 | | |
79 | | - | |
80 | 58 | | |
81 | 59 | | |
82 | 60 | | |
83 | 61 | | |
84 | 62 | | |
85 | 63 | | |
86 | 64 | | |
87 | | - | |
| 65 | + | |
88 | 66 | | |
89 | 67 | | |
90 | 68 | | |
| |||
Lines changed: 0 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
12 | | - | |
13 | | - | |
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
272 | | - | |
273 | 272 | | |
274 | 273 | | |
275 | 274 | | |
| |||
0 commit comments