Skip to content

Commit d4ab9bb

Browse files
mangelajomangelajo
committed
ci: build expirable images for pull-requests
1 parent d7c223c commit d4ab9bb

2 files changed

Lines changed: 20 additions & 2 deletions

File tree

‎.beads/issues.jsonl‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{"id":"controller-258","title":"cert-manager: Update e2e test infrastructure","description":"Update test utils to cert-manager v1.19.2 and add InstallCertManager to e2e BeforeSuite","status":"closed","priority":2,"issue_type":"task","owner":"miguelangel@ajo.es","created_at":"2026-01-23T17:47:18.959542+01:00","created_by":"Miguel Angel Ajo Pelayo","updated_at":"2026-01-23T18:15:45.858233+01:00","closed_at":"2026-01-23T18:15:45.858233+01:00","close_reason":"Closed"}
2+
{"id":"controller-30w","title":"cert-manager: Implement status reconciler","description":"Implement updateStatus to check issuer/certificate readiness and set conditions","status":"closed","priority":2,"issue_type":"task","owner":"miguelangel@ajo.es","created_at":"2026-01-23T17:47:14.217184+01:00","created_by":"Miguel Angel Ajo Pelayo","updated_at":"2026-01-23T18:13:04.302716+01:00","closed_at":"2026-01-23T18:13:04.302716+01:00","close_reason":"Closed"}
3+
{"id":"controller-6ih","title":"cert-manager: Add CertManagerConfig API types","description":"Add CertManagerConfig, ServerCertConfig, SelfSignedConfig, IssuerReference types to jumpstarter_types.go","status":"closed","priority":2,"issue_type":"task","owner":"miguelangel@ajo.es","created_at":"2026-01-23T17:47:04.643674+01:00","created_by":"Miguel Angel Ajo Pelayo","updated_at":"2026-01-23T17:48:58.49702+01:00","closed_at":"2026-01-23T17:48:58.49702+01:00","close_reason":"Closed"}
4+
{"id":"controller-7hb","title":"cert-manager: Add TLS secret mounts to deployments","description":"Modify createControllerDeployment and createRouterDeployment to mount TLS secrets and set env vars","status":"closed","priority":2,"issue_type":"task","owner":"miguelangel@ajo.es","created_at":"2026-01-23T17:47:12.639697+01:00","created_by":"Miguel Angel Ajo Pelayo","updated_at":"2026-01-23T18:11:44.575324+01:00","closed_at":"2026-01-23T18:11:44.575324+01:00","close_reason":"Closed"}
5+
{"id":"controller-a7q","title":"cert-manager: Add RBAC markers for cert-manager resources","description":"Add kubebuilder RBAC markers for cert-manager resources (issuers, certificates)","status":"closed","priority":2,"issue_type":"task","owner":"miguelangel@ajo.es","created_at":"2026-01-23T17:47:15.534073+01:00","created_by":"Miguel Angel Ajo Pelayo","updated_at":"2026-01-23T18:13:36.657172+01:00","closed_at":"2026-01-23T18:13:36.657172+01:00","close_reason":"Closed"}
6+
{"id":"controller-c7i","title":"cert-manager: Add e2e tests for certificate flows","description":"Add e2e tests for self-signed and external issuer certificate flows","status":"closed","priority":2,"issue_type":"task","owner":"miguelangel@ajo.es","created_at":"2026-01-23T17:47:20.125946+01:00","created_by":"Miguel Angel Ajo Pelayo","updated_at":"2026-01-23T18:16:29.832958+01:00","closed_at":"2026-01-23T18:16:29.832958+01:00","close_reason":"Closed"}
7+
{"id":"controller-jrs","title":"cert-manager: Create certificates reconciler","description":"Create certificates.go with reconcileCertificates, reconcileSelfSignedIssuer, reconcileControllerCertificate, reconcileRouterCertificates","status":"closed","priority":2,"issue_type":"task","owner":"miguelangel@ajo.es","created_at":"2026-01-23T17:47:11.146263+01:00","created_by":"Miguel Angel Ajo Pelayo","updated_at":"2026-01-23T18:10:10.449469+01:00","closed_at":"2026-01-23T18:10:10.449469+01:00","close_reason":"Closed"}
8+
{"id":"controller-qky","title":"cert-manager: Add status conditions to JumpstarterStatus","description":"Add Conditions slice to JumpstarterStatus (no separate bool fields - all state via conditions)","status":"closed","priority":2,"issue_type":"task","owner":"miguelangel@ajo.es","created_at":"2026-01-23T17:47:09.203545+01:00","created_by":"Miguel Angel Ajo Pelayo","updated_at":"2026-01-23T17:50:42.310228+01:00","closed_at":"2026-01-23T17:50:42.310228+01:00","close_reason":"Closed"}
9+
{"id":"controller-rub","title":"cert-manager: Update hack scripts for cert-manager support","description":"Update controller/hack/utils and deploy_with_operator.sh to support cert-manager installation (USE_CERTMANAGER env var)","status":"closed","priority":2,"issue_type":"task","owner":"miguelangel@ajo.es","created_at":"2026-01-23T17:47:17.249434+01:00","created_by":"Miguel Angel Ajo Pelayo","updated_at":"2026-01-23T18:14:33.7234+01:00","closed_at":"2026-01-23T18:14:33.7234+01:00","close_reason":"Closed"}
10+
{"id":"controller-utt","title":"cert-manager: Generate manifests","description":"Run make generate and make manifests to update CRDs and RBAC","status":"closed","priority":2,"issue_type":"task","owner":"miguelangel@ajo.es","created_at":"2026-01-23T17:47:21.536648+01:00","created_by":"Miguel Angel Ajo Pelayo","updated_at":"2026-01-23T18:16:24.931577+01:00","closed_at":"2026-01-23T18:16:24.931577+01:00","close_reason":"Closed"}

‎.github/workflows/build-images.yaml‎

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,14 @@ on:
88
branches:
99
- main
1010
- 'release-*'
11+
pull_request:
12+
branches:
13+
- main
14+
- 'release-*'
1115
merge_group:
1216

1317
env:
14-
PUSH: ${{ github.repository_owner == 'jumpstarter-dev' && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/') || startsWith(github.ref, 'refs/heads/release-')) }}
18+
PUSH: ${{ github.repository_owner == 'jumpstarter-dev' && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/') || startsWith(github.ref, 'refs/heads/release-') || github.event_name == 'pull_request') }}
1519
REGISTRY: quay.io
1620
QUAY_ORG: quay.io/jumpstarter-dev
1721

@@ -119,6 +123,10 @@ jobs:
119123
uses: docker/metadata-action@v5
120124
with:
121125
images: ${{ env.REGISTRY }}/${{ matrix.image_name }}
126+
tags: |
127+
type=ref,event=pr,prefix=pr-
128+
labels: |
129+
quay.expires-after=${{ github.event_name == 'pull_request' && '7d' || '' }}
122130
123131
- name: Build and push Docker image
124132
id: push
@@ -127,7 +135,7 @@ jobs:
127135
context: ${{ matrix.context }}
128136
file: ${{ matrix.dockerfile }}
129137
push: ${{ env.PUSH }}
130-
tags: ${{ steps.set-tags.outputs.tags }}
138+
tags: ${{ github.event_name == 'pull_request' && steps.meta.outputs.tags || steps.set-tags.outputs.tags }}
131139
labels: ${{ steps.meta.outputs.labels }}
132140
platforms: linux/amd64,linux/arm64
133141
cache-from: type=gha

0 commit comments

Comments
 (0)