Skip to content

Commit f05e107

Browse files
committed
test: disable retry in onFailure=exit e2e tests (B5, C2, H2)
Tests that use exporters configured with onFailure=exit expect the exporter process to terminate. With the new default retry-timeout of 5m, jmp shell would keep retrying until the suite timeout (11m+). Pass --retry-timeout 0 to disable retry so the shell command fails immediately when the exporter exits.
1 parent 764826c commit f05e107

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

e2e/test/hooks_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ var _ = Describe("Hooks E2E Tests", Label("hooks"), Ordered, func() {
205205
startHooksExporterSingle("exporter-hooks-before-fail-exit.yaml")
206206

207207
out, err := Jmp("shell", "--client", "test-client-hooks",
208+
"--retry-timeout", "0",
208209
"--selector", "example.com/board=hooks", "j", "power", "on")
209210
Expect(err).To(HaveOccurred())
210211
Expect(out).To(MatchRegexp(`(beforeLease hook fail|Exporter shutting down|Connection to exporter lost)`))
@@ -239,6 +240,7 @@ var _ = Describe("Hooks E2E Tests", Label("hooks"), Ordered, func() {
239240

240241
// Shell may succeed or fail; the key is the exporter exits
241242
_, _ = Jmp("shell", "--client", "test-client-hooks",
243+
"--retry-timeout", "0",
242244
"--selector", "example.com/board=hooks", "j", "power", "on")
243245

244246
Eventually(func() bool {
@@ -411,6 +413,7 @@ print("PYTHON_HOOK: complete")
411413
startHooksExporterSingle("exporter-hooks-before-fail-exit-with-after.yaml")
412414

413415
out, err := Jmp("shell", "--client", "test-client-hooks",
416+
"--retry-timeout", "0",
414417
"--selector", "example.com/board=hooks", "j", "power", "on")
415418
Expect(err).To(HaveOccurred())
416419
Expect(out).NotTo(ContainSubstring("AFTER_SHOULD_NOT_RUN"))

0 commit comments

Comments
 (0)