feat: use generateName for leases to allow alias reuse after deletion

Leases created with --lease-id now use K8s generateName instead of a
fixed Name. The user-provided alias is stored as a label and resolved
transparently in Get/Delete/Update via a name-or-alias lookup. This
prevents the "already exists" error when re-creating a lease with the
same --lease-id after deletion (since deletion is a soft-delete that
leaves the K8s object in etcd).

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Assisted-by: claude-opus-4.6

Author: bennyz

controller/api/v1alpha1/lease_helpers.go

@@ -320,6 +320,9 @@ func (l *Lease) ToProtobuf() *cpb.Lease {
 			Name:      l.Status.ExporterRef.Name,
 		}))
 	}
+	if alias, ok := l.Labels[string(LeaseLabelName)]; ok {
+		lease.Alias = ptr.To(alias)
+	}
 
 	return &lease
 }

controller/api/v1alpha1/lease_helpers_test.go

@@ -521,4 +521,44 @@ var _ = Describe("Lease.ToProtobuf", func() {
 
 		Expect(pb.Tags).To(BeEmpty())
 	})
+
+	It("should populate alias from lease-name label", func() {
+		lease := &Lease{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "demo-x7k2q",
+				Namespace: "default",
+				Labels: map[string]string{
+					string(LeaseLabelName): "demo",
+				},
+			},
+			Spec: LeaseSpec{
+				ClientRef: corev1.LocalObjectReference{Name: "test-client"},
+				Duration:  &metav1.Duration{Duration: time.Hour},
+				Selector:  metav1.LabelSelector{MatchLabels: map[string]string{"board": "rpi4"}},
+			},
+		}
+
+		pb := lease.ToProtobuf()
+
+		Expect(pb.Alias).NotTo(BeNil())
+		Expect(*pb.Alias).To(Equal("demo"))
+	})
+
+	It("should not set alias when lease-name label is absent", func() {
+		lease := &Lease{
+			ObjectMeta: metav1.ObjectMeta{
+				Name:      "lease-m9p3r",
+				Namespace: "default",
+			},
+			Spec: LeaseSpec{
+				ClientRef: corev1.LocalObjectReference{Name: "test-client"},
+				Duration:  &metav1.Duration{Duration: time.Hour},
+				Selector:  metav1.LabelSelector{MatchLabels: map[string]string{"board": "rpi4"}},
+			},
+		}
+
+		pb := lease.ToProtobuf()
+
+		Expect(pb.Alias).To(BeNil())
+	})
 })

controller/api/v1alpha1/lease_types.go

@@ -82,6 +82,7 @@ type LeaseLabel string
 const (
 	LeaseLabelEnded        LeaseLabel = "jumpstarter.dev/lease-ended"
 	LeaseLabelEndedValue   string     = "true"
+	LeaseLabelName         LeaseLabel = "jumpstarter.dev/lease-name"
 	LeaseTagMetadataPrefix string     = "metadata.jumpstarter.dev/"
 )