Lease filtering doesn't work

[mangelajo]

(venv) rnoriega@fedora:~/nvidia-jetson-sidecar$ jmp get leases -l name=nvidia-jetson-nx-orin-01-khw-eng-bos2-beaker -o name
01999fe0-0110-7d52-b498-894bbda44220
0199a001-d58d-769f-a32d-caf85a5a4d5e
(venv) rnoriega@fedora:~/nvidia-jetson-sidecar$ jmp get leases
NAME                           SELECTOR                     DURATION  CLIENT                    EXPORTER
01999fe0-0110-7d52-b498-894b…  name=majopela-orin-nx        4:00:00   ncao                      majopela-orin-nx
0199a001-d58d-769f-a32d-caf8…  name=nvidia-jetson-nx-orin…  1:00:00   gitlab-runner-eco-nvidia  nvidia-jetson-nx-orin-01-khw…

[NickCao]

Remove the selector for now until we figure out what do users actually expect for when filtering for leases.

[mangelajo]

Remove the selector for now until we figure out what do users actually expect for when filtering for leases.

Agreed,

As we discussed it's confusing, and could mean:

• Selecting labels for the Leases themselves (the lease object) (current, and not what users expect)
• Selecting labels for the acquired exporters on leases
• Selecting labels for the lease selectors ...

and not really a necessary feature now, so the proposal is ... let's drop it, and if users request this , we will have a user story and real world feedback on how is this expected to work.

[evakhoni]

I think it's covered by my two recent PRs: #168 #174
currently, the implemented logic have server doing a simple match labels filtering, while the client further refine the results with complex match expressions.

the implementation is filtering against the selector used at lease acquiring, rather than against the exporter labels themselves. which may or may not be confusing, but for now it seems to me like a progress in comparison to the previous state, where a lease would not have any meaningful labels to filter from.

imo we can close this one for now, as the filtering does work, but we may want to collect user feedback whatever filtering by matching against exporters, and listing the leases that acquired that matched exporters, is more desirable vs the current.