Skip to content

ci(e2e): run operator e2e on main push, drop helm matrix#406

Merged
mangelajo merged 1 commit into
mainfrom
ci/e2e-operator-main-push
Apr 8, 2026
Merged

ci(e2e): run operator e2e on main push, drop helm matrix#406
mangelajo merged 1 commit into
mainfrom
ci/e2e-operator-main-push

Conversation

@mangelajo

Copy link
Copy Markdown
Member
  • Trigger workflow on push to main so merges are covered.
  • Run e2e with METHOD=operator only; remove helm matrix leg and ARM/helm exclude.

Made-with: Cursor

@netlify

netlify Bot commented Apr 6, 2026

Copy link
Copy Markdown

Deploy Preview for jumpstarter-docs ready!

Name Link
🔨 Latest commit b96098a
🔍 Latest deploy log https://app.netlify.com/projects/jumpstarter-docs/deploys/69d4d418bd824c00084bfffb
😎 Deploy Preview https://deploy-preview-406--jumpstarter-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@mangelajo has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 3 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 21 minutes and 3 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 57d67818-9134-49a0-979c-810d50b48edd

📥 Commits

Reviewing files that changed from the base of the PR and between e1735c4 and b96098a.

📒 Files selected for processing (1)
  • .github/workflows/e2e.yaml
📝 Walkthrough

Walkthrough

Updated the e2e GitHub Actions workflow: added a push trigger for the main branch, removed the method matrix (operator/helm) and ARM-specific exclusion, and set METHOD to operator for setup and run steps.

Changes

Cohort / File(s) Summary
E2E Workflow Configuration
​.github/workflows/e2e.yaml
Added push trigger for main. Replaced dorny/paths-filter base fallback with github.ref. Removed method matrix dimension and ARM exclusion; hardcoded METHOD=operator in make e2e-setup and make e2e-run steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • evakhoni

Poem

🐰 I hopped through YAML, tidy and bright,
One METHOD now, no branching fight,
Push to main and tests will start,
A simpler path — straight from the heart. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes: triggering CI on push to main and removing the helm matrix dimension from the e2e workflow.
Description check ✅ Passed The description is directly related to the changeset, outlining the key objectives of triggering on main push and removing the helm matrix leg.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/e2e-operator-main-push

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mangelajo mangelajo requested review from kirkbrauer and raballew April 7, 2026 07:28
@mangelajo

Copy link
Copy Markdown
Member Author

some tests marked as missing, but just because we need to change the project config due to the new matrix.

@raballew raballew left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR correctly:

  • Adds push trigger on main branch for e2e tests
  • Removes helm from the matrix method dimension
  • Removes the ARM/helm exclude rule
  • Hardcodes METHOD: operator instead of using ${{ matrix.method }}

One medium-severity concern identified below regarding the interaction between the new push trigger and the existing dorny/paths-filter gate.


on:
workflow_dispatch:
push:

@raballew raballew Apr 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI-generated, human reviewed]

With the new push trigger, the e2e-tests job condition at line 38 may skip tests on push-to-main:

if: needs.changes.outputs.should_run == 'true' || github.event_name == 'workflow_dispatch'

For push events, github.base_ref is empty, so dorny/paths-filter falls back to the base parameter ('main'). On squash merges or force-pushes, the push payload's before SHA may not be a direct ancestor, causing the filter to produce unexpected results. Since the if condition doesn't include github.event_name == 'push', e2e tests could be silently skipped on push to main.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right, I forgot we had that filter, checking, thanks! :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now the filtering base is fixed, and we always run the main E2E tests on all pushes (not the compat ones), as we just want an indication of any patch introducing flakiness in our codebase over the time.

@mangelajo

Copy link
Copy Markdown
Member Author

@raballew Thanks for the detailed review.

paths-filter on push: Updated the base input to fall back to github.ref instead of the literal 'main'. That matches dorny/paths-filter’s long-lived-branch behavior: when the workflow is triggered by a push and base is the same branch ref as the push, changes are detected against the previous commit on that branch—avoiding the weak default we had when github.base_ref was empty.

Job if: We’re not adding a blanket push bypass; downstream jobs still use needs.changes.outputs.should_run == 'true' || github.event_name == 'workflow_dispatch' and rely on the corrected filter (option A).

Pushed as a single amended commit on ci/e2e-operator-main-push (fixup squashed). If anything still looks off, happy to adjust.

@mangelajo mangelajo force-pushed the ci/e2e-operator-main-push branch 2 times, most recently from e1735c4 to 2130b39 Compare April 7, 2026 09:52
- Trigger workflow on push to main so merges are covered.
- Run e2e with METHOD=operator only; remove helm matrix leg and ARM/helm exclude.

Made-with: Cursor
@mangelajo mangelajo force-pushed the ci/e2e-operator-main-push branch from 2130b39 to b96098a Compare April 7, 2026 09:53
@mangelajo mangelajo requested a review from raballew April 7, 2026 09:54
@mangelajo mangelajo merged commit 0d05519 into main Apr 8, 2026
22 checks passed
@raballew raballew deleted the ci/e2e-operator-main-push branch June 5, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants