Skip to content

update fls to 0.3.0#838

Merged
mangelajo merged 1 commit into
jumpstarter-dev:mainfrom
bennyz:bump-fls
Jun 24, 2026
Merged

update fls to 0.3.0#838
mangelajo merged 1 commit into
jumpstarter-dev:mainfrom
bennyz:bump-fls

Conversation

@bennyz

@bennyz bennyz commented Jun 24, 2026

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 15bb0f62-4144-4de3-8cd3-ad35f3f2a320

📥 Commits

Reviewing files that changed from the base of the PR and between f9d6f93 and 3c02009.

📒 Files selected for processing (2)
  • python/Containerfile
  • python/packages/jumpstarter-driver-flashers/jumpstarter_driver_flashers/client.py

📝 Walkthrough

Walkthrough

Bumps the FLS_VERSION Docker build argument default from 0.2.0 to 0.3.0 in python/Containerfile, and changes the --fls-version CLI option default from "0.2.0" to "" in the flashers driver client.

Changes

FLS version bump and CLI default reset

Layer / File(s) Summary
FLS version bump in Containerfile and CLI default reset
python/Containerfile, python/packages/jumpstarter-driver-flashers/jumpstarter_driver_flashers/client.py
FLS_VERSION build arg default updated to 0.3.0; --fls-version CLI option default changed from "0.2.0" to "" so no version is assumed when the option is omitted.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

Suggested labels

build-pr-images

Suggested reviewers

  • mangelajo

Poem

🐇 Hippity-hop, a new version's here,
0.3.0 of fls, let's give a cheer!
The default's now blank, no version assumed,
The image is fresh, the old string consumed.
This rabbit approves — the build is groomed! 🎉

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided, so the check cannot assess its relevance beyond absence. Add a short description summarizing the FLS version bump and the CLI default version change.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: updating FLS to version 0.3.0.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mangelajo mangelajo added this pull request to the merge queue Jun 24, 2026
Merged via the queue into jumpstarter-dev:main with commit c29eece Jun 24, 2026
39 of 42 checks passed
@bennyz bennyz deleted the bump-fls branch June 24, 2026 16:03
@bennyz bennyz mentioned this pull request Jun 24, 2026
evakhoni pushed a commit to evakhoni/jumpstarter that referenced this pull request Jun 24, 2026
partial revert of
jumpstarter-dev#838 due to
defaulting to "" breaking flashing

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants