Skip to content

use 0.3.0 default for CLI#839

Merged
mangelajo merged 1 commit into
jumpstarter-dev:mainfrom
bennyz:fix-fls-bump
Jun 24, 2026
Merged

use 0.3.0 default for CLI#839
mangelajo merged 1 commit into
jumpstarter-dev:mainfrom
bennyz:fix-fls-bump

Conversation

@bennyz

@bennyz bennyz commented Jun 24, 2026

Copy link
Copy Markdown
Member

partial revert of #838 due to defaulting to "" breaking flashing

partial revert of jumpstarter-dev#838
due to defaulting to "" breaking flashing

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
@bennyz bennyz requested a review from mangelajo June 24, 2026 16:04
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 351e335e-af01-46a3-bd24-e41cec26457f

📥 Commits

Reviewing files that changed from the base of the PR and between c29eece and 3430f4d.

📒 Files selected for processing (1)
  • python/packages/jumpstarter-driver-flashers/jumpstarter_driver_flashers/client.py

📝 Walkthrough

Walkthrough

The default value of fls_version is changed from "" to "0.3.0" in two places within client.py: the BaseFlasherClient.flash method signature and the CLI --fls-version option. This causes both the programmatic API and the CLI to download FLS release 0.3.0 when no version is explicitly supplied.

Changes

FLS Version Default Update

Layer / File(s) Summary
fls_version default: API method and CLI option
python/packages/jumpstarter-driver-flashers/jumpstarter_driver_flashers/client.py
BaseFlasherClient.flash parameter default and --fls-version CLI option default both updated from "" to "0.3.0", so the FLS 0.3.0 release is downloaded when no version is specified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • mangelajo

Poem

🐇 Hop, hop, hooray for version new!
The flasher knows just what to do,
No more empty string to confuse the code —
"0.3.0" lights the download road.
A sensible default, fresh and true! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: restoring the 0.3.0 default for the CLI.
Description check ✅ Passed The description is directly related and explains the revert motivation and flashing issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bennyz bennyz added this to the 0.9.0 milestone Jun 24, 2026

@mangelajo mangelajo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right, the busybox image..

@mangelajo mangelajo enabled auto-merge June 24, 2026 16:46
@mangelajo mangelajo added this pull request to the merge queue Jun 24, 2026
Merged via the queue into jumpstarter-dev:main with commit a899a44 Jun 24, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants