Avoid potential NPEs for String.equals() calls

Author: marcphilipp

gradle/config/checkstyle/checkstyleMain.xml

@@ -36,6 +36,7 @@
 		</module>
 		<module name="HideUtilityClassConstructor"/>
 		<module name="ModifierOrder"/>
+		<module name="EqualsAvoidNull"/>
 	</module>
 
 	<module name="JavadocPackage" />

junit-jupiter-params/src/main/java/org/junit/jupiter/params/ParameterizedInvocationNameFormatter.java

@@ -57,7 +57,7 @@ static ParameterizedInvocationNameFormatter create(ExtensionContext extensionCon
 			ParameterizedDeclarationContext<?> declarationContext) {
 
 		String name = declarationContext.getDisplayNamePattern();
-		String pattern = name.equals(DEFAULT_DISPLAY_NAME)
+		String pattern = DEFAULT_DISPLAY_NAME.equals(name)
 				? extensionContext.getConfigurationParameter(DISPLAY_NAME_PATTERN_KEY) //
 						.orElse(DEFAULT_DISPLAY_NAME_PATTERN)
 				: name;

junit-platform-commons/src/main/java/org/junit/platform/commons/util/AnnotationUtils.java

@@ -381,7 +381,7 @@ private static boolean isRepeatableAnnotationContainer(Class<? extends Annotatio
 		return repeatableAnnotationContainerCache.computeIfAbsent(candidateContainerType, candidate -> {
 			// @formatter:off
 			Repeatable repeatable = Arrays.stream(candidate.getMethods())
-					.filter(attribute -> attribute.getName().equals("value") && attribute.getReturnType().isArray())
+					.filter(attribute -> "value".equals(attribute.getName()) && attribute.getReturnType().isArray())
 					.findFirst()
 					.map(attribute -> attribute.getReturnType().getComponentType().getAnnotation(Repeatable.class))
 					.orElse(null);

junit-platform-commons/src/main/java/org/junit/platform/commons/util/ModuleUtils.java

@@ -223,7 +223,7 @@ List<Class<?>> scan(ModuleReference reference) {
 					// @formatter:off
 					return names.filter(name -> name.endsWith(".class"))
 							.map(this::className)
-							.filter(name -> !name.equals("module-info"))
+							.filter(name -> !"module-info".equals(name))
 							.filter(classFilter::match)
 							.<Class<?>> map(this::loadClassUnchecked)
 							.filter(classFilter::match)

platform-tooling-support-tests/src/main/java/platform/tooling/support/Helper.java

@@ -51,8 +51,8 @@ public static List<String> loadModuleDirectoryNames() {
 					.filter(Matcher::matches) //
 					.map(matcher -> matcher.group(1)) //
 					.filter(name -> name.startsWith("junit-")) //
-					.filter(name -> !name.equals("junit-bom")) //
-					.filter(name -> !name.equals("junit-platform-console-standalone")).toList();
+					.filter(name -> !"junit-bom".equals(name)) //
+					.filter(name -> !"junit-platform-console-standalone".equals(name)).toList();
 		}
 		catch (Exception e) {
 			throw new AssertionError("loading module directory names failed: " + SETTINGS_GRADLE);