Include class template invocation index in legacy reporting names (Backport to 5.14)#5527
Include class template invocation index in legacy reporting names (Backport to 5.14)#5527amilbourne wants to merge 3 commits intojunit-team:releases/5.14.xfrom
Conversation
|
@marcphilipp Is this backport OK? |
|
@amilbourne Yes, we need to discuss what else to backport and when first, though. I'll eventually get back to you but it may take some time. |
|
OK, thanks for the response. I realise you probably have many other things to do. |
|
@amilbourne Would you mind adding #5524 to this PR as well so merging it will close #5618? |
|
Yes, I can do that. |
This is a backport of commit b9756dd Changes were made to compile under Java 8 Co-authored-by: Marc Philipp <mail@marcphilipp.de> Signed-off-by: Anthony Milbourne <18662115+amilbourne@users.noreply.github.com>
Rather than just including the display name of the test, the display names of all ancestors are now included as well, separated by the `>` character. This includes display names of parents otherwise not represented in the legacy XML format (for example, the invocation of a `@ParameterizedClass`). This is a backport of commit ee3a100 Changes were made to compile under Java 8 Co-authored-by: Marc Philipp <mail@marcphilipp.de> Signed-off-by: Anthony Milbourne <18662115+amilbourne@users.noreply.github.com>
0cfa129 to
c16129e
Compare
|
I think I have done that. Obviously, let me know if there are problems. |
|
Build is failing but that looks unrelated to this PR. |
|
Fixed by 14f534d. |
|
I've merged this PR manually in fbd4a8e and ac01f2d yo preserve the two commits but keep history linear. Thanks again, @amilbourne! 👍 |
This is a backport of commit b9756dd which stems from #5409 & #5441
as well as commit ee3a100 which stems from #5524 & #5618
Changes were made to compile under Java 8
I have updated release notes but not sure if this is the correct procedure.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations