Skip to content

Include class template invocation index in legacy reporting names (Backport to 5.14)#5527

Closed
amilbourne wants to merge 3 commits intojunit-team:releases/5.14.xfrom
amilbourne:backport/5441-to-5.14.x
Closed

Include class template invocation index in legacy reporting names (Backport to 5.14)#5527
amilbourne wants to merge 3 commits intojunit-team:releases/5.14.xfrom
amilbourne:backport/5441-to-5.14.x

Conversation

@amilbourne
Copy link
Copy Markdown

@amilbourne amilbourne commented Mar 18, 2026

This is a backport of commit b9756dd which stems from #5409 & #5441
as well as commit ee3a100 which stems from #5524 & #5618

Changes were made to compile under Java 8

I have updated release notes but not sure if this is the correct procedure.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@amilbourne
Copy link
Copy Markdown
Author

@marcphilipp Is this backport OK?

@marcphilipp
Copy link
Copy Markdown
Member

@amilbourne Yes, we need to discuss what else to backport and when first, though. I'll eventually get back to you but it may take some time.

@amilbourne
Copy link
Copy Markdown
Author

OK, thanks for the response. I realise you probably have many other things to do.

@marcphilipp
Copy link
Copy Markdown
Member

@amilbourne Would you mind adding #5524 to this PR as well so merging it will close #5618?

@amilbourne
Copy link
Copy Markdown
Author

Yes, I can do that.

amilbourne and others added 2 commits April 20, 2026 18:43
This is a backport of commit b9756dd

Changes were made to compile under Java 8

Co-authored-by: Marc Philipp <mail@marcphilipp.de>
Signed-off-by: Anthony Milbourne <18662115+amilbourne@users.noreply.github.com>
Rather than just including the display name of the test, the display
names of all ancestors are now included as well, separated by the `>`
character. This includes display names of parents otherwise not
represented in the legacy XML format (for example, the invocation of a
`@ParameterizedClass`).

This is a backport of commit ee3a100

Changes were made to compile under Java 8

Co-authored-by: Marc Philipp <mail@marcphilipp.de>
Signed-off-by: Anthony Milbourne <18662115+amilbourne@users.noreply.github.com>
@amilbourne amilbourne force-pushed the backport/5441-to-5.14.x branch from 0cfa129 to c16129e Compare April 21, 2026 02:10
@amilbourne
Copy link
Copy Markdown
Author

I think I have done that. Obviously, let me know if there are problems.
I re-pushed the original commit so they wee both signed (not sure if it matters).
I updated the PR description but not the title.

@mpkorstanje
Copy link
Copy Markdown
Contributor

Build is failing but that looks unrelated to this PR.

@mpkorstanje
Copy link
Copy Markdown
Contributor

Fixed by 14f534d.

@marcphilipp
Copy link
Copy Markdown
Member

I've merged this PR manually in fbd4a8e and ac01f2d yo preserve the two commits but keep history linear.

Thanks again, @amilbourne! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Legacy XML reports generated for @ParameterizedClass tests do not contain parameters (backport)

3 participants