docs: use functions canisters lib in calls example (#591)

* docs: use functions canisters lib in calls example

Signed-off-by: David Dal Busco <david.dalbusco@outlook.com>

* 📄 Update LLMs.txt snapshot for PR review

---------

Signed-off-by: David Dal Busco <david.dalbusco@outlook.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

Author: peterpeterparker

.llms-snapshots/llms-full.txt

@@ -5162,7 +5162,7 @@ You can browse the source code here: [github.com/junobuild/examples/tree/main/fu
 ## Folder Structure
 
 ```
-typescript/calls/├── src/│   ├── satellite/           # TypeScript Satellite serverless function│   │   ├── index.ts         # Main TypeScript logic for Satellite│   │   ├── services.ts      # Helper logic for balance, transfer, status│   │   ├── ledger-icrc.ts   # Ledger helper functions│   │   └── tsconfig.json    # TypeScript config for Satellite│   ├── declarations/│   │   └── satellite/       # TypeScript declarations for Satellite│   ├── components/          # React frontend components│   ├── services/            # Frontend service logic│   ├── types/               # Frontend type definitions│   ├── main.tsx             # Frontend entry│   └── ...├── juno.config.ts           # Juno Satellite configuration├── package.json             # Frontend dependencies└── ...
+typescript/calls/├── src/│   ├── satellite/           # TypeScript Satellite serverless function│   │   ├── index.ts         # Main TypeScript logic for Satellite│   │   ├── services.ts      # Helper logic for balance, transfer, status│   │   └── tsconfig.json    # TypeScript config for Satellite│   ├── declarations/│   │   └── satellite/       # TypeScript declarations for Satellite│   ├── components/          # React frontend components│   ├── services/            # Frontend service logic│   ├── types/               # Frontend type definitions│   ├── main.tsx             # Frontend entry│   └── ...├── juno.config.ts           # Juno Satellite configuration├── package.json             # Frontend dependencies└── ...
 ```
 
 ---
@@ -5180,7 +5180,6 @@ typescript/calls/├── src/│   ├── satellite/           # TypeScript
 
 *   **src/satellite/index.ts**: The entry point for the Satellite serverless function. Triggers the canister call and updates request status on document set.
 *   **src/satellite/services.ts**: Helper logic for checking wallet balance, performing the transfer, and updating request status.
-*   **src/satellite/ledger-icrc.ts**: Helper functions for interacting with the ICRC ledger.
 *   **src/types/request.ts**: Data model for requests and status.
 
 ---
@@ -5190,11 +5189,11 @@ typescript/calls/├── src/│   ├── satellite/           # TypeScript
 Here’s the actual TypeScript logic from `index.ts` and `services.ts`:
 
 ```
-// src/satellite/index.tsimport { Account } from "@dfinity/ledger-icrc/dist/candid/icrc_ledger";import { Principal } from "@dfinity/principal";import {  type AssertSetDoc,  defineAssert,  defineHook,  type OnSetDoc} from "@junobuild/functions";import { id } from "@junobuild/functions/ic-cdk";import { decodeDocData } from "@junobuild/functions/sdk";import { COLLECTION_REQUEST, ICP_LEDGER_ID } from "../constants/app.constants";import { RequestData, RequestDataSchema } from "../types/request";import {  assertWalletBalance,  setRequestProcessed,  transferIcpFromWallet} from "./services";export const assertSetDoc = defineAssert<AssertSetDoc>({  collections: [COLLECTION_REQUEST],  assert: (context) => {    // We validate that the data submitted for create or update matches the expected schema.    const person = decodeDocData<RequestData>(context.data.data.proposed.data);    RequestDataSchema.parse(person);  }});export const onSetDoc = defineHook<OnSetDoc>({  collections: [COLLECTION_REQUEST],  run: async (context) => {    // Init data    const {      data: {        key,        data: {          after: { version }        }      }    } = context;    const data = decodeDocData<RequestData>(context.data.data.after.data);    const { amount: requestAmount, fee } = data;    const ledgerId = ICP_LEDGER_ID;    const fromAccount: Account = {      owner: Principal.fromUint8Array(context.caller),      subaccount: []    };    // Check current account balance    await assertWalletBalance({      ledgerId,      fromAccount,      amount: requestAmount,      fee    });    // Update request status to processed (atomic with transfer)    setRequestProcessed({      key,      version,      data    });    // Transfer from wallet to satellite    const toAccount: Account = {      owner: id(),      subaccount: []    };    await transferIcpFromWallet({      ledgerId,      fromAccount,      toAccount,      amount: requestAmount,      fee    });  }});
+// src/satellite/index.tsimport { Principal } from "@icp-sdk/core/principal";import {  type AssertSetDoc,  defineAssert,  defineHook,  type OnSetDoc} from "@junobuild/functions";import { IcrcLedgerDid } from "@junobuild/functions/canisters/ledger/icrc";import { id } from "@junobuild/functions/ic-cdk";import { decodeDocData } from "@junobuild/functions/sdk";import { COLLECTION_REQUEST, ICP_LEDGER_ID } from "../constants/app.constants";import { RequestData, RequestDataSchema } from "../types/request";import {  assertWalletBalance,  setRequestProcessed,  transferIcpFromWallet} from "./services";export const assertSetDoc = defineAssert<AssertSetDoc>({  collections: [COLLECTION_REQUEST],  assert: (context) => {    // We validate that the data submitted for create or update matches the expected schema.    const person = decodeDocData<RequestData>(context.data.data.proposed.data);    RequestDataSchema.parse(person);  }});export const onSetDoc = defineHook<OnSetDoc>({  collections: [COLLECTION_REQUEST],  run: async (context) => {    // ###############    // Init data    // ###############    const {      data: {        key,        data: {          after: { version }        }      }    } = context;    const data = decodeDocData<RequestData>(context.data.data.after.data);    const { amount: requestAmount, fee } = data;    const ledgerId = ICP_LEDGER_ID;    const fromAccount: IcrcLedgerDid.Account = {      owner: Principal.fromUint8Array(context.caller),      subaccount: []    };    // ###############    // Check current account balance. This way the process can stop early on    // ###############    await assertWalletBalance({      ledgerId,      fromAccount,      amount: requestAmount,      fee    });    // ###############    // The request is about to be processed by transferring the amount via the ICP ledger.    // We update the status beforehand. Since the function is atomic, a failed transfer reverts everything.    // This avoids a case where the transfer succeeds but the status isn't updated — even if unlikely.    // This is for demo only. In production, proper error handling and bookkeeping would be required.    // ###############    setRequestProcessed({      key,      version,      data    });    // ###############    // Transfer from wallet to satellite.    // ###############    const toAccount: IcrcLedgerDid.Account = {      owner: id(),      subaccount: []    };    await transferIcpFromWallet({      ledgerId,      fromAccount,      toAccount,      amount: requestAmount,      fee    });    console.log(`${requestAmount} ICP transferred to Satellite 🥳`);  }});
 ```
 
 ```
-// src/satellite/services.tsexport const assertWalletBalance = async ({  ledgerId,  fromAccount,  amount,  fee}: {  ledgerId: Principal;  fromAccount: Account;  amount: bigint;  fee: bigint | undefined;}) => {  const balance = await icrcBalanceOf({    ledgerId,    account: fromAccount  });  const total = amount + (fee ?? IC_TRANSACTION_FEE_ICP);  if (balance < total) {    throw new Error(      `Balance ${balance} is smaller than ${total} for account ${fromAccount.owner.toText()}.`    );  }};export const transferIcpFromWallet = async (params: {  ledgerId: Principal;  fromAccount: Account;  toAccount: Account;  amount: bigint;  fee: bigint | undefined;}): Promise<bigint> => {  const result = await icrcTransferFrom(params);  if ("Err" in result) {    throw new Error(      `Failed to transfer ICP from wallet: ${JSON.stringify(result)}`    );  }  return result.Ok;};export const setRequestProcessed = ({  key,  data: currentData,  version: originalVersion}: {  key: string;  data: RequestData;  version: bigint | undefined;}) => {  const updateData: RequestData = {    ...currentData,    status: "processed"  };  const data = encodeDocData(updateData);  const doc: SetDoc = {    data,    version: originalVersion  };  setDocStore({    caller: id(),    collection: COLLECTION_REQUEST,    doc,    key  });};
+// src/satellite/services.tsexport const assertWalletBalance = async ({  ledgerId,  fromAccount,  amount,  fee}: {  ledgerId: Principal;  fromAccount: IcrcLedgerDid.Account;  amount: bigint;  fee: bigint | undefined;}) => {  const { icrc1BalanceOf } = new IcrcLedgerCanister({ canisterId: ledgerId });  const balance = await icrc1BalanceOf({    account: fromAccount  });  const total = amount + (fee ?? IC_TRANSACTION_FEE_ICP);  if (balance < total) {    const encodedAccountText = encodeIcrcAccount({      owner: fromAccount.owner,      subaccount: fromNullable(fromAccount.subaccount)    });    throw new Error(      `Balance ${balance} is smaller than ${total} for account ${encodedAccountText}.`    );  }};export const transferIcpFromWallet = async ({  ledgerId,  fromAccount,  amount,  fee,  toAccount}: {  ledgerId: Principal;  fromAccount: IcrcLedgerDid.Account;  toAccount: IcrcLedgerDid.Account;  amount: bigint;  fee: bigint | undefined;}): Promise<IcrcLedgerDid.Tokens> => {  const args: IcrcLedgerDid.TransferFromArgs = {    amount,    from: fromAccount,    to: toAccount,    created_at_time: toNullable(),    fee: toNullable(fee),    memo: toNullable(),    spender_subaccount: toNullable()  };  const { icrc2TransferFrom } = new IcrcLedgerCanister({    canisterId: ledgerId  });  const result = await icrc2TransferFrom({ args });  if ("Err" in result) {    throw new Error(      `Failed to transfer ICP from wallet: ${JSON.stringify(result, jsonReplacer)}`    );  }  return result.Ok;};export const setRequestProcessed = ({  key,  data: currentData,  version: originalVersion}: {  key: string;  data: RequestData;  version: bigint | undefined;}) => {  const updateData: RequestData = {    ...currentData,    status: "processed"  };  const data = encodeDocData(updateData);  const doc: SetDoc = {    data,    version: originalVersion  };  setDocStore({    caller: id(),    collection: COLLECTION_REQUEST,    doc,    key  });};
 ```
 
 **Explanation:**

docs/examples/functions/typescript/canister-calls.mdx

@@ -5,6 +5,7 @@ keywords:
   [
     typescript,
     canister call,
+    ledger,
     transfer_from,
     icrc,
     icp,
@@ -40,7 +41,6 @@ typescript/calls/
 │   ├── satellite/           # TypeScript Satellite serverless function
 │   │   ├── index.ts         # Main TypeScript logic for Satellite
 │   │   ├── services.ts      # Helper logic for balance, transfer, status
-│   │   ├── ledger-icrc.ts   # Ledger helper functions
 │   │   └── tsconfig.json    # TypeScript config for Satellite
 │   ├── declarations/
 │   │   └── satellite/       # TypeScript declarations for Satellite
@@ -69,7 +69,6 @@ typescript/calls/
 
 - **src/satellite/index.ts**: The entry point for the Satellite serverless function. Triggers the canister call and updates request status on document set.
 - **src/satellite/services.ts**: Helper logic for checking wallet balance, performing the transfer, and updating request status.
-- **src/satellite/ledger-icrc.ts**: Helper functions for interacting with the ICRC ledger.
 - **src/types/request.ts**: Data model for requests and status.
 
 ---
@@ -80,14 +79,14 @@ Here’s the actual TypeScript logic from `index.ts` and `services.ts`:
 
 ```ts
 // src/satellite/index.ts
-import { Account } from "@dfinity/ledger-icrc/dist/candid/icrc_ledger";
-import { Principal } from "@dfinity/principal";
+import { Principal } from "@icp-sdk/core/principal";
 import {
   type AssertSetDoc,
   defineAssert,
   defineHook,
   type OnSetDoc
 } from "@junobuild/functions";
+import { IcrcLedgerDid } from "@junobuild/functions/canisters/ledger/icrc";
 import { id } from "@junobuild/functions/ic-cdk";
 import { decodeDocData } from "@junobuild/functions/sdk";
 import { COLLECTION_REQUEST, ICP_LEDGER_ID } from "../constants/app.constants";
@@ -103,14 +102,18 @@ export const assertSetDoc = defineAssert<AssertSetDoc>({
   assert: (context) => {
     // We validate that the data submitted for create or update matches the expected schema.
     const person = decodeDocData<RequestData>(context.data.data.proposed.data);
+
     RequestDataSchema.parse(person);
   }
 });
 
 export const onSetDoc = defineHook<OnSetDoc>({
   collections: [COLLECTION_REQUEST],
   run: async (context) => {
+    // ###############
     // Init data
+    // ###############
+
     const {
       data: {
         key,
@@ -119,38 +122,59 @@ export const onSetDoc = defineHook<OnSetDoc>({
         }
       }
     } = context;
+
     const data = decodeDocData<RequestData>(context.data.data.after.data);
+
     const { amount: requestAmount, fee } = data;
+
     const ledgerId = ICP_LEDGER_ID;
-    const fromAccount: Account = {
+
+    const fromAccount: IcrcLedgerDid.Account = {
       owner: Principal.fromUint8Array(context.caller),
       subaccount: []
     };
-    // Check current account balance
+
+    // ###############
+    // Check current account balance. This way the process can stop early on
+    // ###############
     await assertWalletBalance({
       ledgerId,
       fromAccount,
       amount: requestAmount,
       fee
     });
-    // Update request status to processed (atomic with transfer)
+
+    // ###############
+    // The request is about to be processed by transferring the amount via the ICP ledger.
+    // We update the status beforehand. Since the function is atomic, a failed transfer reverts everything.
+    // This avoids a case where the transfer succeeds but the status isn't updated — even if unlikely.
+    // This is for demo only. In production, proper error handling and bookkeeping would be required.
+    // ###############
+
     setRequestProcessed({
       key,
       version,
       data
     });
-    // Transfer from wallet to satellite
-    const toAccount: Account = {
+
+    // ###############
+    // Transfer from wallet to satellite.
+    // ###############
+
+    const toAccount: IcrcLedgerDid.Account = {
       owner: id(),
       subaccount: []
     };
+
     await transferIcpFromWallet({
       ledgerId,
       fromAccount,
       toAccount,
       amount: requestAmount,
       fee
     });
+
+    console.log(`${requestAmount} ICP transferred to Satellite 🥳`);
   }
 });
 ```
@@ -164,35 +188,65 @@ export const assertWalletBalance = async ({
   fee
 }: {
   ledgerId: Principal;
-  fromAccount: Account;
+  fromAccount: IcrcLedgerDid.Account;
   amount: bigint;
   fee: bigint | undefined;
 }) => {
-  const balance = await icrcBalanceOf({
-    ledgerId,
+  const { icrc1BalanceOf } = new IcrcLedgerCanister({ canisterId: ledgerId });
+
+  const balance = await icrc1BalanceOf({
     account: fromAccount
   });
+
   const total = amount + (fee ?? IC_TRANSACTION_FEE_ICP);
+
   if (balance < total) {
+    const encodedAccountText = encodeIcrcAccount({
+      owner: fromAccount.owner,
+      subaccount: fromNullable(fromAccount.subaccount)
+    });
+
     throw new Error(
-      `Balance ${balance} is smaller than ${total} for account ${fromAccount.owner.toText()}.`
+      `Balance ${balance} is smaller than ${total} for account ${encodedAccountText}.`
     );
   }
 };
 
-export const transferIcpFromWallet = async (params: {
+export const transferIcpFromWallet = async ({
+  ledgerId,
+  fromAccount,
+  amount,
+  fee,
+  toAccount
+}: {
   ledgerId: Principal;
-  fromAccount: Account;
-  toAccount: Account;
+  fromAccount: IcrcLedgerDid.Account;
+  toAccount: IcrcLedgerDid.Account;
   amount: bigint;
   fee: bigint | undefined;
-}): Promise<bigint> => {
-  const result = await icrcTransferFrom(params);
+}): Promise<IcrcLedgerDid.Tokens> => {
+  const args: IcrcLedgerDid.TransferFromArgs = {
+    amount,
+    from: fromAccount,
+    to: toAccount,
+    created_at_time: toNullable(),
+    fee: toNullable(fee),
+    memo: toNullable(),
+    spender_subaccount: toNullable()
+  };
+
+  const { icrc2TransferFrom } = new IcrcLedgerCanister({
+    canisterId: ledgerId
+  });
+
+  const result = await icrc2TransferFrom({ args });
+
   if ("Err" in result) {
     throw new Error(
-      `Failed to transfer ICP from wallet: ${JSON.stringify(result)}`
+      `Failed to transfer ICP from wallet: ${JSON.stringify(result, jsonReplacer)}`
     );
   }
+
   return result.Ok;
 };
 
@@ -209,11 +263,14 @@ export const setRequestProcessed = ({
     ...currentData,
     status: "processed"
   };
+
   const data = encodeDocData(updateData);
+
   const doc: SetDoc = {
     data,
     version: originalVersion
   };
+
   setDocStore({
     caller: id(),
     collection: COLLECTION_REQUEST,