Skip to content

Fix labeled string values bug #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamesalster wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −3
Open

Fix labeled string values bug #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a48b03
allow writing string labeled values
jamesalster Nov 6, 2025
873273e
allow parser to read string values
jamesalster Nov 6, 2025
1b036df
add test
jamesalster Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added data/string_labeled_value_eg.sav
View file
Open in desktop
Binary file not shown.
7 changes: 5 additions & 2 deletions src/parser.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,13 @@ end
function _handle_value_label!(val_labels, value, label, vallabels)
lblname = Symbol(_string(val_labels))
type = value_type(value)
# String variables do not have value labels
# All integers are Int32 and all floats are Float64 (ReadStat handles type conversion)
# Tentatively save tagged missing values as Char
if Int(type) <= 3
if type == READSTAT_TYPE_STRING
lbls = get!(Dict{Union{String,Char},String}, vallabels, lblname)
val = value_is_tagged_missing(value) ? value_tag(value) : _string(string_value(value))
lbls[val] = _string(label)
elseif Int(type) <= 3
lbls = get!(Dict{Union{Int32,Char},String}, vallabels, lblname)
val = value_is_tagged_missing(value) ? value_tag(value) : int32_value(value)
lbls[val] = _string(label)
Expand Down
3 changes: 2 additions & 1 deletion src/writestat.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ function _readstat_string_width(col)
elseif nonmissingtype(eltype(col)) == Char
return Csize_t(1)
else
maxlen = maximum(col) do str
string_col = eltype(col) <: LabeledValue ? refarray(col) : col
maxlen = maximum(string_col) do str
ismissing(str) ? 0 : ncodeunits(str)
end
return Csize_t(maxlen)
Expand Down
8 changes: 8 additions & 0 deletions test/readstat.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,14 @@ end
@test m.notes == ["some test text as notes", " (Entered 15-Aug-2018)",
"some other comments", " (Entered 15-Aug-2018)"]
@test m.file_ext == ".sav"

# Test for string values, #52
sav2 = "$(@__DIR__)/../data/string_labeled_value_eg.sav"
d2 = readstat(sav2)
@test eltype(d2[1]) == LabeledValue{String, Union{Char, String}}
@test refarray(d2[1]) == ["BE33", "BE35"]
@test valuelabels(d2[1]) == ["Prov. Liege", "Prov. Namur"]

end

@testset "readstat por" begin
Expand Down
Loading